Merge feat/add-query-protocol branch into develop#673
Merged
Conversation
* smithy-aws-core: add support for awsQuery protocol * codegen: generate AwsQueryClientProtocol for awsQuery services and generate protocol tests
jonathan343
approved these changes
Apr 1, 2026
Contributor
jonathan343
left a comment
There was a problem hiding this comment.
Great work @arandito! These changes seem mergable in this state. I think we might end up refactoring some of the work on the smithy-aws-core side once we define a more common hierarchy for non-binding aws protocols. But I don't think we should block this on that.
I was able to run an additional sanity check by code generating the SNS client and making successful calls. The code generated clients currently default to an aiohttp based client (since there are no event streaming operations) which works, however, when I swap in the CRT based client, I'm seeing the following error:
smithy_core.exceptions.SmithyError: 2056 (AWS_ERROR_HTTP_MISSING_BODY_STREAM): Given the provided headers (ex: Content-Length), a body is expected.
This is something for us to look into as a follow up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR merges the
feat/add-query-protocolfeature branch intodevelop, adding AWS Query protocol support and generic XML deserialization to smithy-python.Related PRs in
feat/add-query-protocol:In addition to the above, this PR includes:
ca5b8c92— Updates the smithy-xml initial version to0.0.0to prepare for releaseTesting
STS test script
Output
How to Run Protocol Tests
make install source .venv/bin/activate make test-protocolsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.