exponential backoff for ws reconnection#130
Open
FelipeTrost wants to merge 2 commits intosnapcast:developfrom
Open
exponential backoff for ws reconnection#130FelipeTrost wants to merge 2 commits intosnapcast:developfrom
FelipeTrost wants to merge 2 commits intosnapcast:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mobile devices WS connections close after a few seconds of closing the browser, having to wait a 1s each time I open the website feels a bit slow.
In this PR I implemented exponential backoff for the reconnection delay like this:
(1.1 ^ reconnectionAttempts) - 1.The -1 is so that the first reconnection happens instantly.
PS: I even think, no delay at all is the best way to go.