[General] Avoid unnecessary object allocations#4147
Open
j-piasecki wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces avoidable object/tuple allocations in the v3 hook utilities by replacing generic iteration/spread patterns with direct property assignment and fixed-key iteration, lowering per-render/per-gesture overhead in hot paths.
Changes:
reanimatedUtils: switch fromObject.entries(config)scanning to iterating known callback keys to detect worklet handlers.eventHandlersUtils: avoid creating intermediate objects via conditional spreads when memoizing gesture callbacks.configUtils: replaceObject.assign+ single-key object creation with direct assignment into the filtered config.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react-native-gesture-handler/src/v3/hooks/utils/reanimatedUtils.ts | Avoids Object.entries tuple allocations by iterating the known callback key set when checking for worklet handlers. |
| packages/react-native-gesture-handler/src/v3/hooks/utils/eventHandlersUtils.ts | Avoids conditional-spread object allocations when building the memoized callbacks object. |
| packages/react-native-gesture-handler/src/v3/hooks/utils/configUtils.ts | Avoids allocating { [key]: value } objects by assigning filtered config props directly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary object allocations:
configUtils- instead of usingObject.assignand creating an object with a single key, the value is now assigned directlyeventHandlerUtils- instead of allocating an object for each callback (even when undefined), the value is now assigned directlyreanimatedUtils- instead of iterating over the entire config, allocating a[key, value]tuple for each field, iterate over the known callbacksTest plan
Run the example app