Skip to content

[WIP] Calculate S-DAC carbon revenue [SAM-EM + BICYCLE-EM] [v3.14]#152

Closed
softwareengineerprogrammer wants to merge 9 commits into
mainfrom
s-dac-carbon-revenue
Closed

[WIP] Calculate S-DAC carbon revenue [SAM-EM + BICYCLE-EM] [v3.14]#152
softwareengineerprogrammer wants to merge 9 commits into
mainfrom
s-dac-carbon-revenue

Conversation

@softwareengineerprogrammer
Copy link
Copy Markdown
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented May 19, 2026

Description

Addresses NatLabRockies#341

TODO

  1. 🚧 SAM-EM support: e30dc21
    1. S-DAC-GT-2 example name/description finalization
  2. Documentation

Testing & Verification

  1. Unit tests added:
    1. S-DAC-GT-2
  2. Unit tests updated:
    1. S-DAC-GT
    2. test_parse_sdacgt_profile
  3. Manual testing:
    1. 🚧 Web interface:
      1. https://gtp.scientificwebservices.com/geophires/?geophires-example-id=S-DAC-GT
      2. https://gtp.scientificwebservices.com/geophires/?geophires-example-id=S-DAC-GT-2

Change Checklist:

Observe the following checklist items if your change includes a new version (see versioning notes and version management docs).

Before merging:

  1. Add a CHANGELOG entry (example). RST Template:
4.14: `TITLE <https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER>`__ | `release <https://github.com/NREL/GEOPHIRES-X/releases/tag/v3.14.P>`__

After merging:

  1. Push tag(s) to GitHub: git push origin refs/tags/v3.14.P
  2. Post a change announcement to the GEOPHIRES Change Announcements Discussion (example). Markdown template:
3.14: [TITLE](https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER) | [release](https://github.com/NREL/GEOPHIRES-X/releases/tag/vM.m.P)

Self-reviewed in #152

Other TODO:

  1. Increase MC allowed number of outputs from 10 Limitation was specific to web interface, not GEOPHIRES MC

@softwareengineerprogrammer softwareengineerprogrammer added the bug Something isn't working label May 19, 2026
@softwareengineerprogrammer softwareengineerprogrammer changed the title Calculate S-DAC carbon revenue [WIP] Calculate S-DAC carbon revenue [v3.14] May 19, 2026
@softwareengineerprogrammer softwareengineerprogrammer changed the title [WIP] Calculate S-DAC carbon revenue [v3.14] [WIP] Calculate S-DAC carbon revenue [SAM-EM + BICYCLE-EM] [v3.14] May 20, 2026
@softwareengineerprogrammer
Copy link
Copy Markdown
Owner Author

Tentatively pausing/abandoning for now in favor of #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant