pc/device.c: remove unused argument to ctap_init()#646
Open
scgtrp wants to merge 1 commit intosolokeys:masterfrom
Open
pc/device.c: remove unused argument to ctap_init()#646scgtrp wants to merge 1 commit intosolokeys:masterfrom
scgtrp wants to merge 1 commit intosolokeys:masterfrom
Conversation
`ctap_init` doesn't take an argument. It hasn't taken an argument since 2019 (e8d0ad5). But due to a quirk of C that was [finally removed in C23](https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2841.htm), passing it an argument was valid. Now it isn't, and this project no longer builds, so this PR removes the bit that makes it not build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctap_initdoesn't take an argument. It hasn't taken an argument since 2019 (e8d0ad5).But due to a quirk of C that was finally removed in C23, passing it an argument was valid. Now it isn't, and this project no longer builds, so this PR removes the bit that makes it not build.