Closed
Conversation
we need this, so we can mount the socket into the servermon container. with abstract unix sockets this is not possible.
we want to avoid that users upload configs that will lead to broken servers (e.g. player not being able to join, because wrong server port etc.). so we change them before building the checkpoint.
we set default configs to make sure that we always have a working config present
turns out, we need can't simply use player forwarding of none. the backend server will not accept the connection. setting the velocity secret has one big disadvantage: if the secret is ever leaked, all checkpoints need to be re-computed.
we tried to use the workload id as the pod id when talking to the CRI to delete the pod. now try to find the pod by the workload id label first to get the pod id.
we also needed to introduce a platformd user, because envoy is running a no-root user container and having the socket owned by root caused permission denied errors.
not waiting until all reconciliations are done will lead to each reconcilation loop trying to do the same operation multiple times even though it is currently ongoing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.