Repository navigation
docs(testing): test the critical path and its failures, fewer tests, and keep them fast - #5
Merged
Merged
Conversation
…and keep them fast
…ch rules to their sources
…ocumented text stays pinned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Rewrites
docs/testing.mdinto four groups: what to test, how many, how a test checks, and speed. The four current rules stay (two gain a sentence); seven are new. Each rule cites its source.Why
The current rules say what a test may assert, but not what to test, how many tests are enough, or how fast they must be. Agents writing tests have produced many near-duplicate tests and slow suites.
tests/utils/url-utils.spec.tsholds 75 tests for an 85-line module.Left out: a per-case limit (no source sets one for every runner), a whole-gate limit (each repo's gate owns that), and coverage thresholds (a call per repo).
No issue: docs
How you checked it
Every link returns 200; the coverage quote is on the cited page; ISTQB §4.2 and §5.2 are equivalence partitioning and risk management.
A second review checked each rule against its cited page; rules the sources don't state are marked as these repos' choice, and rule 1 now caps tests per change.
The repository has no check to run on docs.
A bug fix comes with a test that fails without it
Docs match how it works now
No secrets or private information