Repository navigation
ci: give each push to main its own concurrency group - #103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.github/workflows/ci.yml: theconcurrencygroup wasci-${{ github.ref }}for every run. It is now${{ github.event_name == 'pull_request' && format('{0}-{1}', github.workflow, github.head_ref) || github.run_id }}: pull request runs share a group per workflow and branch (and still cancel older runs, ascancel-in-progressalready did), and every other run, a push tomainincluded, gets a group of its own.Why
With one
ci-refs/heads/maingroup, a run queued behind another push tomainwas replaced by the next one, so that commit never got a CI result. 3 CI runs onmainended cancelled this way (between 2026-10-24 and 2026-10-31). The repository standards say pull request runs share a group per workflow and pull request, and that other runs get their own group "so a run onmainis never replaced" ("CI", splitleafhq/.githubdocs/repo-standards.md).No issue: ci.
How you checked it
actionlint .github/workflows/ci.yml: 0.scripts/checkthrough the pre-push hook: exit 0 (35 s).A bug fix comes with a test that fails without it
Docs match how it works now
No secrets or private information