Fix NPE and add support for generic return types in AsyncMcpToolProvider#5920
Open
luoshengming wants to merge 1 commit intospring-projects:mainfrom
Open
Fix NPE and add support for generic return types in AsyncMcpToolProvider#5920luoshengming wants to merge 1 commit intospring-projects:mainfrom
luoshengming wants to merge 1 commit intospring-projects:mainfrom
Conversation
- Fix potential IllegalArgumentException when typeArgument is ParameterizedType - Add support for ParameterizedType (e.g., Mono<ApiResponse<String>>) - Use generateFromType() for parameterized types to preserve generic information - Add test case to verify generic return type schema generation This fix aligns AsyncMcpToolProvider with SyncMcpToolProvider's approach of using generateFromType() for handling generic return types. Signed-off-by: luoshengming <luoshengming@hotmail.com>
a2eb659 to
5737534
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
AsyncMcpToolProviderwhere using generic return types (e.g.,Mono<ApiResponse<String>>) would cause anIllegalArgumentExceptiondue to passing null toClassUtils.isPrimitiveOrWrapper().Problem
When a tool method returns a parameterized type like
Mono<ApiResponse<T>>, thetypeArgumentextracted from the return type is aParameterizedType, not aClass<?>. The original code would setmethodReturnTypeto null and then pass it toClassUtils.isPrimitiveOrWrapper(), which throwsIllegalArgumentException: Class must not be null.Solution
Class<?>andParameterizedTypeseparately using pattern matchingParameterizedType, useMcpJsonSchemaGenerator.generateFromType()instead ofgenerateFromClass()SyncMcpToolProviderhandles generic return typesTesting
Added test case
testGetToolSpecificationsWithGenericReturnType()that verifies generic return types are properly handled and output schema is correctly generated.Impact