Remove OpenAI AI setters from options#5960
Closed
sdeleuze wants to merge 10 commits intospring-projects:mainfrom
Closed
Remove OpenAI AI setters from options#5960sdeleuze wants to merge 10 commits intospring-projects:mainfrom
sdeleuze wants to merge 10 commits intospring-projects:mainfrom
Conversation
Member
|
The class |
ericbottard
reviewed
May 7, 2026
- Remove `@NestedConfigurationProperty` from `OpenAiChatOptions` - Expose options directly under the `spring.ai.openai.chat` prefix instead of `spring.ai.openai.chat.options` - Implement Spring Boot deprecation mechanism for the legacy `options` nested properties to gracefully guide users during upgrades Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
sdeleuze
force-pushed
the
openai-ai-remove-options
branch
from
3729ea9 to
8770847
Compare
Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
| this.options = options; | ||
| } | ||
|
|
||
| public class Options { |
Member
There was a problem hiding this comment.
These options don't include the properties from AbstractOpenAiOptions (which are now getting deprecated). For instance, the property spring.ai.openai.chat.base-url is no longer supported/deprecated.
Member
|
OpenAiBindingsPropertiesProcessor and TanzuBindingsPropertiesProcessor need to be fixed with the changes. |
Member
|
Can we add a note at the upgrade-notes on the changes introduced as part of these ongoing changes with the deprecations across the models? |
…ptions Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
…operties Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
sdeleuze
force-pushed
the
openai-ai-remove-options
branch
from
cfadb87 to
d9506b3
Compare
Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
sdeleuze
force-pushed
the
openai-ai-remove-options
branch
from
a989131 to
4c4a2dc
Compare
ilayaperumalg
approved these changes
May 7, 2026
Member
|
Rebased and merged without squashing the commits to make it easier to go through the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@NestedConfigurationPropertyfromOpenAiChatOptionsspring.ai.openai.chatprefix instead ofspring.ai.openai.chat.optionsoptionsnested properties to gracefully guide users during upgrades