Repository navigation
Add default descriptions for more Hibernate Validator constraints - #1066
Open
chuuminggg wants to merge 1 commit into
Open
chuuminggg wants to merge 1 commit into
chuuminggg wants to merge 1 commit into
Conversation
Add default constraint descriptions for Hibernate Validator's BitcoinAddress, ISBN, Normalized, UniqueElements, and UUID constraints. Previously, documenting a property annotated with one of these constraints failed with a MissingResourceException unless a custom description had been provided. Fixes spring-projectsgh-1065 Signed-off-by: chuuminggg <rorrxr@naver.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-1065
This adds default constraint descriptions for the following Hibernate Validator constraints:
BitcoinAddressISBNNormalizedUniqueElementsUUIDPreviously, documenting a property that uses one of these constraints failed with a
MissingResourceExceptionunless a custom description was provided. The descriptions follow the style of the existing ones (for example,URLandCreditCardNumber), and the list of supported constraints in the reference documentation has been updated.DurationMin,DurationMax, and the country-specific constraints have been left out for now, as mentioned in the issue.While updating the reference documentation, I noticed that its list of Hibernate Validator constraints also contains
SafeHtmland Hibernate Validator'sEmail,NotBlank, andNotEmpty, which no longer exist in Hibernate Validator 9, and thatCurrencyis listed twice. I've left these as they are to keep this change focused, but I'm happy to clean them up here or separately if you'd like.