Skip to content

minor build updates 2023-01#43

Closed
brody2consult wants to merge 3 commits intosqlcipher:masterfrom
brody2consult:minor-build-updates-2023-01
Closed

minor build updates 2023-01#43
brody2consult wants to merge 3 commits intosqlcipher:masterfrom
brody2consult:minor-build-updates-2023-01

Conversation

@brody2consult
Copy link

@brody2consult brody2consult commented Jan 9, 2023

includes android-database-sqlcipher 4.5.3 update from PR #42


UPDATED STATUS:

I would now favor this over the major updates proposed in PR #44

I would now favor the major updates proposed in PR #44.

@brody2consult brody2consult marked this pull request as ready for review January 9, 2023 01:44
@brody2consult
Copy link
Author

brody2consult commented Jan 9, 2023

I am thinking again it would be ideal to close this in favor of the major updates proposed in PR #44, hope one of these proposals will be considered to keep this test suite updated.

@brody2consult brody2consult marked this pull request as draft January 9, 2023 21:38
@brody2consult
Copy link
Author

Looks like e113fa2 would be overridden by 2cf379d on master ... I would like to rebase the other changes

@brody2consult brody2consult force-pushed the minor-build-updates-2023-01 branch from 5e99082 to aac516e Compare January 10, 2023 20:04
@brody2consult brody2consult marked this pull request as ready for review January 10, 2023 20:37
@brody2consult
Copy link
Author

I am now closing this in favor of the major build updates I proposed in PR #44, don't think #44 will break anything now that we are using SDK 33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant