Add keyboard adjustment additional insets#614
Draft
robmaceachern wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
Behavior.keyboardAdjustmentAdditionalInsetsAPI so Listable consumers can account for persistent overlays while Listable is adjustingcontentInsetfor an overlapping keyboard.This lets UIKit's first-responder auto-scroll treat UI such as floating bottom bars as unavailable space during keyboard avoidance, without requiring clients to take over the full
customScrollViewInsetscalculation.Validation
xcodebuild -workspace Development/ListableDevelopment.xcworkspace -scheme ListableUI -destination 'platform=iOS Simulator,name=iPhone 17' buildxcodebuild test -workspace Development/ListableDevelopment.xcworkspace -scheme Listable -destination 'platform=iOS Simulator,name=iPhone 17' -only-testing:ListableTests/BehaviorTests -only-testing:ListableTests/ListViewTests/test_calculateScrollViewInsetsNotes
Full
Listabletest run currently has one unrelated failure inListableBuilderTests.test_available(["1", "3"]vs["2", "3"]). The touched tests pass.This response was drafted with AI assistance.