Ansible 2.19 compatibility improvements

[jovial]

• Fix broken conditionals
• Use bool filter consistently

See: https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.19.html

[gemini-code-assist]

Summary of Changes

Hello @jovial, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the Ansible playbooks to ensure full compatibility with Ansible 2.19. The changes primarily involve modernizing conditional logic within tasks and handlers by explicitly converting variables to boolean types using the bool filter or the is truthy test. This proactive adjustment addresses potential breaking changes in how Ansible evaluates boolean expressions, thereby maintaining the reliability and functionality of the automation workflows.

Highlights

• Ansible 2.19 Compatibility: Updated conditional statements across several Ansible tasks and handlers to align with changes in boolean variable evaluation in Ansible 2.19, preventing potential breakage.
• Consistent Boolean Filtering: Implemented the | bool filter for variables used in when conditions to explicitly cast them to boolean types, ensuring consistent and correct evaluation.
• Truthy Test Adoption: Replaced implicit boolean evaluation with the is truthy test for specific variables in when conditions, enhancing clarity and compatibility with newer Ansible versions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the Ansible roles for compatibility with Ansible 2.19 by fixing conditionals. The use of the bool filter for boolean variables and is truthy for other variables aligns with the porting guide. I've suggested one minor improvement to make a conditional more concise and readable, but otherwise, the changes are solid.

[Alex-Welsh]

The ansible 2.20 linter's decided to scope-creep you. Do you want to fix that in this PR or make a separate one?

[MoteHue]

The ansible 2.20 linter's decided to scope-creep you. Do you want to fix that in this PR or make a separate one?

#47 This should have made the linter happy, I think we'd just need a rebase