Add defaults for GPU PCI passthrough#1586
Conversation
115d514 to
8a06ffb
Compare
0856eb0 to
9cd7720
Compare
|
This should be using the stackhpc.linux collection if possible: stackhpc/ansible-collection-linux#28 |
2c3562c to
bbd2eaa
Compare
Agreed, though I'd rather get this merged so we can start using it, then update once the collection supports it |
|
I tried out the changes on a client deployment with three GPU types, worked very well |
MoteHue
left a comment
There was a problem hiding this comment.
Just some docs changes now.
I've used this at a different customer site, worked a treat
Co-authored-by: Matt Crees <mattc@stackhpc.com>
e8d6a54 to
9a9b4e8
Compare
|
Since we're not far from the 2025.1 release, should we target that instead? |
As long as we backport, because we'll still need this for deployments before the next upgrade season |
If we want it in 2024.1 anyway, we should just include it here and merge it up like normal |
MoteHue
left a comment
There was a problem hiding this comment.
LGTM now, thanks @Alex-Welsh!
|
bringing defaults nova-scheduling filters for everybody - not sure if that is best way. Plus empty pci stanzas in default nova configs. Can this be refactored as a opt-in feature ? - potentially as a gpu-passthrough mix-in environment, or at least opt-in variable. |
This change is designed to drastically simplify pci passthrough GPU configuration.
The idea is that we have a data dictionary containing common GPU types, and templating to write that data to nova config files based on a simple group-to-gpu map.
Configuring passthrough is as simple as creating a dictionary like this:
(and passing through the group names to Kolla-Ansible)
The
pci-passthrough.ymlplaybook manages host configuration (and is pre-hooked to overcloud host configure)Templates for
nova-compute.conf,nova-api.conf, andnova-scheduler.confhave been added.Changes have now been tested in a prod environment