Skip to content

feat: Add InternalIPs to CreateMachineResponse#140

Open
jamand wants to merge 3 commits intomainfrom
feat/add-machine-internal-ip-status-field
Open

feat: Add InternalIPs to CreateMachineResponse#140
jamand wants to merge 3 commits intomainfrom
feat/add-machine-internal-ip-status-field

Conversation

@jamand
Copy link
Member

@jamand jamand commented Mar 16, 2026

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

Similar to gardener/machine-controller-manager-provider-openstack#322
Server InternalIPs are now returned on created Machines, so that they may be used for access. This is needed, as the provided hostname field already written into is the Machine Status.Addresses is not resolvable on STACKIT.

Which issue(s) this PR fixes:
x

Special notes for your reviewer:

The client Suite was previously not registered and there was a small bug in one test case.

/hold Running tests first

@ske-prow ske-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Enhancement, improvement, extension size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 16, 2026
@jamand jamand force-pushed the feat/add-machine-internal-ip-status-field branch from 0a4a0d5 to 2e0be67 Compare March 16, 2026 13:57
@ske-prow
Copy link

ske-prow bot commented Mar 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from breuerfelix. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jamand jamand force-pushed the feat/add-machine-internal-ip-status-field branch from 8439761 to 8f95f5f Compare March 20, 2026 11:35
Co-authored-by: Felix Breuer <f.breuer94@gmail.com>
@jamand jamand force-pushed the feat/add-machine-internal-ip-status-field branch from 8f95f5f to d39fd9f Compare March 20, 2026 11:43
@jamand
Copy link
Member Author

jamand commented Mar 20, 2026

@breuerfelix Thanks!

I also ran a test in an ondemand environment testing the self-hosted shoot scenario using gardenadm (only in this case the IP is written into the Status field. I could verify that the Addresses field now has an additional entry with the server internal IP (Type: InternalIP) next to the already previously created Hostname entry.

@jamand
Copy link
Member Author

jamand commented Mar 20, 2026

/unhold

@ske-prow ske-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Enhancement, improvement, extension size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants