Skip to content

Use snapshot tests - #481

Draft
VisruthSK wants to merge 11 commits into
masterfrom
use-snapshots
Draft

VisruthSK wants to merge 11 commits into
masterfrom
use-snapshots

Conversation

@VisruthSK

Copy link
Copy Markdown
Member

This PR was LLM assisted

Summary

Swap some tests to use snapshots instead of regex for checking how objects are printed.

Wait for #476, don't think I can stack.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@VisruthSK VisruthSK added the test Improvements or additions to unit tests label Nov 15, 2026
@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 35988d7 is merged into master:

  • 🚀as_draws_array: 93.7ms -> 91.5ms [-2.88%, -1.75%]
  • 🚀as_draws_df: 29.3ms -> 29ms [-1.43%, -0.51%]
  • ✔️as_draws_list: 149ms -> 148ms [-1.4%, +0.07%]
  • ✔️as_draws_matrix: 23.6ms -> 23.5ms [-0.88%, +0.62%]
  • ✔️as_draws_rvars: 69.8ms -> 69.5ms [-2.52%, +1.57%]
  • ✔️summarise_draws_100_variables: 585ms -> 586ms [-0.14%, +0.28%]
  • ✔️summarise_draws_10_variables: 65.1ms -> 64.9ms [-0.97%, +0.19%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@VisruthSK
VisruthSK marked this pull request as ready for review November 17, 2026 21:25
@VisruthSK
VisruthSK marked this pull request as draft November 17, 2026 21:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Improvements or additions to unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants