Repository navigation
Skip PSIS tail smoothing when a quarter of the tail ties at its minimum - #3451
Merged
Merged
Conversation
WardBrian
approved these changes
Nov 5, 2026
WardBrian
enabled auto-merge
November 5, 2026 21:33
Contributor
Jenkins Console Log Machine informationDistributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 46 bits physical, 48 bits virtual CPU(s): 80 On-line CPU(s) list: 0-79 Thread(s) per core: 2 Core(s) per socket: 20 Socket(s): 2 NUMA node(s): 2 Vendor ID: GenuineIntel CPU family: 6 Model: 85 Model name: Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz Stepping: 7 CPU MHz: 1000.000 CPU max MHz: 3900.0000 CPU min MHz: 1000.0000 BogoMIPS: 5000.00 L1d cache: 1.3 MiB L1i cache: 1.3 MiB L2 cache: 40 MiB L3 cache: 55 MiB NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78 NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79 Vulnerability Gather data sampling: Mitigation; Microcode Vulnerability Indirect target selection: Mitigation; Aligned branch/return thunks Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable Vulnerability Old microcode: Not affected Vulnerability Reg file data sampling: Not affected Vulnerability Retbleed: Mitigation; Enhanced IBRS Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Enhanced / Automatic IBRS; IBPB conditional; PBRSB-eIBRS SW sequence; BHI SW loop, KVM SW loop Vulnerability Srbds: Not affected Vulnerability Tsa: Not affected Vulnerability Tsx async abort: Mitigation; TSX disabled Vulnerability Vmscape: Mitigation; IBPB before exit to userspace Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 intel_ppin ssbd mba ibrs ibpb stibp ibrs_enhanced fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke avx512_vnni md_clear flush_l1d arch_capabilities G++: g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 Copyright (C) 2019 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Clang: clang version 10.0.0-4ubuntu1 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was assisted by Claude. The reference code in R was written by human.
Summary
Zhang and Stephens (2009) method requires that first quartile is bigger than the smallest value.
psis_smooth_tail()passes the excessesexp(lw_tail) - exp(cutoff)togpdfit(). When a quarter of them are 0, the first quartilex_1st_qtis 0, and the gridthetadivides by it and becomes-Inf. The product-theta * xis then NaN for the zero excesses, sokandsigmaare NaN. The test!std::isinf(k)lets NaN through, the smoothed tail is NaN, and(llr_weights.array() < 0.0).select(llr_weights, 0.0)maps NaN to 0. Each tail draw gets the weightexp(0) = 1. Thek > 0.7warning does not fire for NaN.Zero excesses occur in these cases:
exp()underflows to 0 for them;-Inf, whichsingle.hppsets when the log density throws astd::domain_error.Example (100 draws, tail length 20): 70 log ratios from -20 to -26.9, 15 at -5, and 15 from -3.5 to 0. The cutoff and 5 tail values are -5.
developreturns 1 for all 20 tail draws; the correct unsmoothed weights areexp(lr), for exampleexp(-5) = 0.0067for the 5 tied draws.When the tied minimum is positive (a quarter of the tail ties above the cutoff),
thetais finite, andgpdfit()fits a sample that is far from a generalized Pareto distribution.posterior::gpdfit()returnsNAfor both cases, with the same check on the first quartile.Intended Effect
gpdfit()returns NaN forsigmaandkwhen the first quartile ofxis not larger than its smallest value.psis_smooth_tail()smooths only for a finitek. Otherwise it returns the tail unchanged.psis_weights()logs a warning whenkis not finite and returns the weights without smoothing, as it already does for a constant tail.This behavior matches the behavior of corresponding function in posterior R package.
How to Verify
./runTests.py src/test/unit/services/pathfinder. The three new tests inpsis_test.cppare:gpdfit_tied_first_quartile: 4 of 20 values at the minimum give a finite fit; 5 of 20 at a minimum of 0, and 5 of 20 at a minimum of 0.001, give NaN.psis_weights_tied_cutoff: the example above. The weights must equalexp(lr), and the warning must be logged.psis_weights_underflow_in_tail: 85 log ratios from -1000 to -1084 and 15 from -3.5 to 0, so 5 tail values and the cutoff underflow. The same checks.With the
developpsis.hppand the new tests, the 3 new tests fail (42 expectations) and the 5 existing tests pass. With this PR all 8 pass.eight_schools_testandnormal_glm_testalso pass.Tested with
develop849cec8daand Stan Mathe4745c87ff, g++ 14.3.0, Linux x86_64.Side Effects
The results do not change when the first quartile of the excesses is larger than their minimum. The existing PSIS tests and the Pathfinder service tests pass without changes. A tail with a quarter of its values tied at a positive minimum is no longer smoothed.
Documentation
gpdfit()andpsis_smooth_tail()describe the new return values.Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Aalto University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: