Skip to content

fix(status): expose actual audio outcomes and read-only DSH plugin status - #117

Merged
cangen185-sudo merged 2 commits into
starsstreaming:mainfrom
cangen185-sudo:codex/fix-audio-results-capabilities
Nov 18, 2026
Merged

cangen185-sudo merged 2 commits into
starsstreaming:mainfrom
cangen185-sudo:codex/fix-audio-results-capabilities

Conversation

@cangen185-sudo

Copy link
Copy Markdown
Collaborator

Audio feedback must distinguish the saved preference from observed window state. Return per-window outcomes, partial failure and nullable actualMuted, retaining existing muted preference semantics. Keep no-video, mixed and failed observations unknown rather than inventing a single playback result.

Add DSH --status as a read-only plugin-file inspection which explicitly leaves wiring and live loading unverified. Document implemented host capabilities, unsupported management/resume combinations and required platform acceptance in docs/host-capabilities.md.

Validation: mocked multi-window audio and console tests passed; existing session behavior and browser playback regressions passed in the integrated run; read-only CLI tests passed. No real audio policy, plugin handshake or client startup was exercised.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1435ca37-a8e6-462d-9bf6-8986eb0f2071
Commits

Reviewing files that changed from the base of the PR and between 44896d2 and 0f57454.

Files selected for processing: 10

  • docs/host-capabilities.md
  • integrations/deepseek-harness/cli.js
  • integrations/deepseek-harness/test/cli-readonly-package.test.mjs
  • integrations/deepseek-harness/test/cli-readonly.test.mjs
  • packages/adapter-codex/src/console-host.ts
  • packages/adapter-codex/src/host-applier.ts
  • packages/adapter-codex/src/renderer/runtime-api.js
  • packages/adapter-codex/src/renderer/runtime-controls.js
  • packages/adapter-codex/src/session.ts
  • packages/adapter-codex/test/audio-outcomes.test.js
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cangen185-sudo
cangen185-sudo merged commit 833965c into starsstreaming:main Nov 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant