Repository navigation
fix(runtime): preserve Node probe errors and isolate copied-executable checks - #118
Merged
cangen185-sudo merged 3 commits intoNov 18, 2026
Conversation
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A process-probe timeout/error was collapsed into the generic no-safe-Node result, making an intermittent copied-executable test hard to diagnose. Preserve sanitized probe failure codes without accepting an unverified executable. Isolate the end-to-end copied-Node fixture with an injected asynchronous probe; production retains its short probe policy.
Validation: the copied executable/runner case passed, and the final integrated serial non-browser run completed with 535 tests: 529 passed, six platform/opt-in skips and zero failures. The earlier failed run remains a separate validation record.
This improves diagnostics and fixture isolation; the original intermittent failure's operating-system cause is still unproven. It does not claim the production environment can never time out.