Skip to content

fix(runtime): preserve Node probe errors and isolate copied-executable checks - #118

Merged
cangen185-sudo merged 3 commits into
starsstreaming:mainfrom
cangen185-sudo:codex/fix-node-probe-diagnostics
Nov 18, 2026
Merged

cangen185-sudo merged 3 commits into
starsstreaming:mainfrom
cangen185-sudo:codex/fix-node-probe-diagnostics

Conversation

@cangen185-sudo

Copy link
Copy Markdown
Collaborator

A process-probe timeout/error was collapsed into the generic no-safe-Node result, making an intermittent copied-executable test hard to diagnose. Preserve sanitized probe failure codes without accepting an unverified executable. Isolate the end-to-end copied-Node fixture with an injected asynchronous probe; production retains its short probe policy.

Validation: the copied executable/runner case passed, and the final integrated serial non-browser run completed with 535 tests: 529 passed, six platform/opt-in skips and zero failures. The earlier failed run remains a separate validation record.

This improves diagnostics and fixture isolation; the original intermittent failure's operating-system cause is still unproven. It does not claim the production environment can never time out.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f4f4bab0-ebb2-43f0-a5f7-e4c9ac2fb130
Commits

Reviewing files that changed from the base of the PR and between 44896d2 and e7281ec.

Files selected for processing: 2

  • packages/beauticode-desktop/test/portable-runtime.test.mjs
  • scripts/portable-runtime.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cangen185-sudo
cangen185-sudo merged commit f9e7daa into starsstreaming:main Nov 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant