[marcelohildebrand]

The Linux Quick View provider tabs showed quota used even when the detailed bar was set to show quota remaining. For example, 60% remaining appeared as a 40% tab bar and a 60% detail bar.

Use the same display preference for both bars. In remaining mode, a full bar means 0% used; in used mode, the direction is reversed.

Validation: QT_QPA_PLATFORM=offscreen QT_QUICK_BACKEND=software qmltestrunner -input Integrations/Linux/tests/qml (passed). The regression test checks both display modes with 60% remaining.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[chatgpt-codex-connector]

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-11T21:07:59.826565Z	ff80735	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[clawsweeper]

Codex review: needs real behavior proof before merge.

What this changes

Make Linux Quick View provider-tab quota bars honor the existing used-or-remaining display preference.

Example: Codex has 60% quota remaining and the display preference is remaining.

• Before: The provider-tab bar is 40% full while the detail bar is 60% full.
• After: Both bars are 60% full; switching to used makes both 40% full.

Review scores

Measure	Result	What it means
Overall readiness	🧂 unranked krab (1/6)	The focused patch appears correct, but the required real-behavior proof is currently limited to a test harness.
Proof confidence	🧂 unranked krab (1/6)	Real behavior proof is necessary before merge. See Before merge.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: Quick View gives conflicting visual quota amounts for the same provider when remaining mode is selected.
Reason: Consistent rendering of an existing preference has clear value and requires no new product surface or setting.

Merge readiness

⛔ Blocked before merge - 1 item remains

This PR fixes a current display inconsistency with a small, focused change; no actionable code defect was found.

Priority: P2
Reviewed head: ff807350cae86a9667acb2c1701c2cf2d438af33

Before merge

• Add real behavior proof - QuickView.qml is exercised by a reported offscreen QML test with a synthetic desktop object, which supports the calculation but does not prove the shipped desktop path; please provide screenshots or a recording from the built Linux app showing 60% remaining in both tab and detail meters, then 40% in used mode, with sensitive account details redacted. After adding proof, update the PR body, then request a new review with @clawsweeper re-review. The PR author or someone with repository write access can request it.

Findings

None.

Tests

• Missing end-to-end proof: The supplied validation does not show the built Linux desktop displaying matching tab and detail bars in both modes, or a base-fail/head-pass regression run.

Agent review details

How this fits together

The Linux desktop supplies provider quota windows and display settings to Quick View, which renders tab, overview, and detail meters through shared presentation helpers.

flowchart TD
    A[Provider quota windows] --> C[Linux desktop model]
    B[Display preference] --> C
    C --> D[Quick View]
    D --> E[Shared quota conversion]
    E --> F[Provider tab meter]
    E --> G[Overview and detail meters]

Loading

Technical review

Best possible solution:

Use the existing quotaValue helper for the tab meter so every Quick View quota surface follows the same preference.

Do we have a high-confidence way to reproduce the issue?

Main directly shows the failure: with remaining=60 and quotaDisplay=remaining, the tab calculates 40 while the detail calculates 60; no target code was executed during this read-only review.

Is this the best way to solve the issue?

The patch is the smallest complete fix: it replaces the inconsistent calculation with the shared presentation owner and preserves existing settings, empty-window behavior, and used mode.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 7447bc77c249.

Provenance checked

• Quick View provider-tab quota calculation keeps the original intent (4b11f05: The original feature aimed to provide compact provider quota meters matching the macOS menu; its body and discussion establish no intentional exemption from the desktop quota-display preference.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

• Verified introduced change: The pinned diff replaces the tab's unconditional used-percentage calculation with the existing quotaValue helper and adds focused coverage for both modes. (Integrations/Linux/qml/QuickView.qml:176, ff807350cae8)
• Current-main inconsistency: Main hardcodes used quota for the tab, while MenuMetric and the Quick View overview already honor quotaDisplay; quotaValue returns remaining unless the mode is used. (Integrations/Linux/Shared/Usage.js:375, 7447bc77c249)
• Original product boundary: Add opt-in Linux Quick View #3973 introduced Quick View as an optional presentation of existing desktop models; steipete's discussion approved that bounded surface while preserving ordinary launch and cached-only spending. (Integrations/Linux/qml/QuickView.qml:174, 4b11f05a88b2)
• Supplied validation: The full PR body reports an offscreen qmltestrunner pass; all discussion comments were read and supply no runtime screenshot, recording, or output showing this fix through the built desktop. (Integrations/Linux/tests/qml/tst_quickview.qml:76, ff807350cae8)
• Policy and history inspection: The complete root AGENTS.md applies; no nested AGENTS.md, maintainer notes, or pr-simplify skill was found. Feature history identifies the original Quick View work and subsequent owner integration. Some historical follow and content searches encountered unavailable partial-clone objects; current and relevant original blobs were independently readable. (AGENTS.md:1, 7447bc77c249)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Review metrics

Metric	Value	Why it matters
Production and test changes	Production +3/-1 lines; tests +9/-0 lines	The change reuses an existing helper and adds one focused two-mode regression case.

Labels

Label changes:

No label changes.

Label justifications:

• P2: The optional Linux Quick View presents contradictory quota amounts, but usage retrieval and the detailed meter remain functional.
• rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🐚 platinum hermit.
• status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (1 earlier review cycle)

• reviewed 2026-11-11T21:19:24.001Z sha ff80735 :: needs real behavior proof before merge. :: none

Reviewed November 11, 2026, 4:21 PM ET / 21:21 UTC (Revision 2).