Skip to content

fix: preserve scenes and report playback failures - #35

Merged
steipete merged 1 commit into
mainfrom
codex/s24-sonoscli
Nov 14, 2026
Merged

steipete merged 1 commit into
mainfrom
codex/s24-sonoscli

Conversation

@steipete

Copy link
Copy Markdown
Owner

Scene saves could silently overwrite real settings with zero values after failed reads; scene application could announce success after speaker commands failed. Enqueue-and-play also reported success when Sonos omitted the newly queued position.

This consolidates #32, #33 and #34. Failed reads preserve the saved file, failed apply commands stop with room context, and missing queue positions return explicit recovery instructions without starting older queue content. The apply policy is fail-fast for commands to visible speakers; absent speakers retain the existing skip behavior, and completed changes are not rolled back. Scene topology now honors an explicit speaker IP. Source compatibility remains Go 1.26; build tooling moves to Go 1.27.4 and pflag to 1.1.0.

Validation: reproduced all seven original failure cases against main, then passed focused regressions, full tests/race suite, 75.9% coverage (87.2% stream proxy), lint, vet, docs build, govulncheck and independent P0–P2 review. Actual CLI proof on an isolated Linux lease used the production HTTP/SOAP transport and file store: a scene saved by the v0.3.5 revision remained byte-identical after both read failures; zero-volume save and legacy-scene restoration passed; each apply error returned nonzero; missing queue position preserved existing content and queued once, explicit recovery played position 2, and a positive position played the new track 3. No household speakers or real accounts were used.

Recorded transport and upgrade proof. Lease stopped after proof. No release, tag or product-version change.

Co-authored-by: Sebastien Tardif sebtardif@ncf.ca

Consolidate scene and enqueue fixes from #32, #33 and #34. Propagate speaker errors, honor explicit scene targets and update compatible build dependencies.

Co-authored-by: Sebastien Tardif <sebtardif@ncf.ca>
@clawsweeper

clawsweeper Bot commented Nov 14, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T08:04:21.866789Z 44347ff PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@steipete
steipete merged commit aeb7c28 into main Nov 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant