Repository navigation
fix: preserve scenes and report playback failures - #35
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scene saves could silently overwrite real settings with zero values after failed reads; scene application could announce success after speaker commands failed. Enqueue-and-play also reported success when Sonos omitted the newly queued position.
This consolidates #32, #33 and #34. Failed reads preserve the saved file, failed apply commands stop with room context, and missing queue positions return explicit recovery instructions without starting older queue content. The apply policy is fail-fast for commands to visible speakers; absent speakers retain the existing skip behavior, and completed changes are not rolled back. Scene topology now honors an explicit speaker IP. Source compatibility remains Go 1.26; build tooling moves to Go 1.27.4 and pflag to 1.1.0.
Validation: reproduced all seven original failure cases against main, then passed focused regressions, full tests/race suite, 75.9% coverage (87.2% stream proxy), lint, vet, docs build, govulncheck and independent P0–P2 review. Actual CLI proof on an isolated Linux lease used the production HTTP/SOAP transport and file store: a scene saved by the v0.3.5 revision remained byte-identical after both read failures; zero-volume save and legacy-scene restoration passed; each apply error returned nonzero; missing queue position preserved existing content and queued once, explicit recovery played position 2, and a positive position played the new track 3. No household speakers or real accounts were used.
Recorded transport and upgrade proof. Lease stopped after proof. No release, tag or product-version change.
Co-authored-by: Sebastien Tardif sebtardif@ncf.ca