Repository navigation
Conversation
ikenyal
marked this pull request as ready for review
November 18, 2026 23:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A literal empty double-quoted word never marked its expansion as a quoted field, so
f "" xlost the empty argument. Preserve that field without changing the zero-argument expansion of"$@".Expand the existing Bash comparison case to check argument counts and values, adjacent quotes, empty variables, and forwarding. The fix also makes the existing empty
casepattern match Bash, so both resolved known-difference markers are removed.Related Issues
Fixes #299
Documentation PR
Not needed; this restores existing behavior.
Type of Change
Bug fix
Testing
cargo test --workspace --all-targets,pytest tests/python,npm test)cargo fmtandcargo clippyValidated on macOS against main after #315 with the full Rust check, workspace doctests, and Node-feature Rust unit tests. Both changes also passed direct CLI checks during initial validation. Existing lint warnings remain.
Checklist
Documentation changes are not needed: this restores existing shell behavior.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.