Modification of M1perp weightedmassoperator, addition of the class Lo…#238
Draft
emilegrivet wants to merge 4 commits intodevelfrom
Draft
Modification of M1perp weightedmassoperator, addition of the class Lo…#238emilegrivet wants to merge 4 commits intodevelfrom
emilegrivet wants to merge 4 commits intodevelfrom
Conversation
…calProjectionMatrix in feec/utilities.py, and modification and addition of two tests in propagators/test_gyrokinetic_poisson.py for M1perp testing.
…_gyrokinetic_poisson, with format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction of the Weighted Mass Operator M1perp to take into account any distribution of magnetic field equilibrium, and modification of the tests in propagators/tests/test_gyrokinetic_poisson.py to verify the implementation of M1perp.
Two tests have been implemented.
The first one is a comparison between two resolutions of a 3d Poisson equation with the diffusion matrix M1 and M1perp, the solutions are then integrated along the third direction (parallel to the magnetic field) and compared (they should be equal).
The second one is a comparison between two resolutions of a Poisson equation in a 3d domain, the first is directly performed over the whole with M1perp. The other resolution consist of multiple of resolutions of 2d Poisson equation along perpendicular (to the magnetic field) slices of the domain. These two resolutions should provide the same results.