Repository navigation
feat: implement interactive tech tree and subtopic popup - #43
Sh4dowking wants to merge 18 commits into
Conversation
Yes of course, I'll do that. I was unaware of the template since I created the pr through the cli |
|
I'll also have a look at your suggested changes shortly 👍 |
|
I wasn't even aware that there was a GitHub CLI. Cool |
|
I pushed the update to the sdk to npm, it will take a few minutes to propagate |
|
Design-wise looks really good |
|
backend container is building and should be ready within about 3 min |
|
Please request a review again when you are done updating or message me in some way |
|
I'm currently working on resolving the issues, almost done! |
| <v-divider class="d-none d-md-block" vertical /> | ||
| <v-divider class="d-md-none my-4" /> | ||
|
|
||
| <div |
There was a problem hiding this comment.
For the assets, as I have previously mentioned, I thought we had decided to go with an asset manager, so maybe extract this bit from there. I guess the delete here should primarily be to de-associate an asset from the subtopic.
| </v-list-item> | ||
| </v-list> | ||
|
|
||
| <div |
There was a problem hiding this comment.
There is a Vuetify component for this and it's pretty neat (and I have a wrapper around it), but again, I think it'd be better to have a global location to upload assets, as an asset may belong to multiple subtopics and to simply open said manager to pick the asset to associate
There was a problem hiding this comment.
General note on this file: It's generally a good practice to keep files below about 200 lines, but since this doesn't need to be very maintainable, it is fine
| "dependencies": { | ||
| "@fontsource/roboto": "^5.2.10", | ||
| "@janishutz/oidc-login-sdk-browser": "^1.7.0", | ||
| "@janishutz/oidc-login-sdk-browser": "^1.7.1", |
There was a problem hiding this comment.
| "@janishutz/oidc-login-sdk-browser": "^1.7.1", | |
| "@janishutz/oidc-login-sdk-browser": "^1.7.2", |
I have since fixed the other issue you mentioned (with the missing export for sendFormData).
| } | ||
| }; | ||
| void init(); |
There was a problem hiding this comment.
| void init(); | |
| init(); |
I didn't even know that was valid TS what you had before, this would also work as far as I can tell
There was a problem hiding this comment.
As a general note, you could extract the popups into separate components, making the code more easily legible, but it's fine if you leave it at this. It could be that some would end up being reusable outside of this.



Description
Implements the interactive Tech Tree view (
/techtree) and subtopic detail workflow:src/ts/util/techtree-layout.ts) with transitive reduction, parent-ordered row placement and unit testssrc/pages/TechTreePage.vue) with pan/zoom, full-viewport sizing, status legend, re-center button, empty-state Create Subject and Create Subtopic dialogs plus header subject creation buttonsrc/components/techtree/TechTreeNode.vue) kept unlocked and clickable across not-started, in-progress and completed statessrc/composables/techtree.ts) with separate backendless sample fixtures (src/composables/techtree-sample.ts), using/subjects/techtree/get/:id,request.patchandrequest.deleteRequestsrc/components/custom-ui-elements/PopupElement.vue) and subtopic detail popup (src/components/techtree/SubtopicDetailPopup.vue) supporting live/subtopics/get/{id}loading, creating/opening/deleting chats across Professor, Student and Detective modes (with sequential<Mode> #Ndefault titles) plus uploading/downloading/deleting assets/chat/:id?view (src/pages/ChatPage.vue) wired cleanly for newly created and existing chatsPart of #9
Breaking changes
None (adds
/techtreeand/chat/:id?routes; awaitsauth.check()insrc/router/index.tsbefore redirecting unauthenticated users; uses the renamed/subjects/techtree/get/:idbackend route)Refactored components
src/components/custom-ui-elements/PopupElement.vue(rebuilt with Vuetify<v-dialog>and<v-sheet>)src/components/SideBar.vue(switched Home, Chats, Subjects and Tech Tree links fromhrefto Vue Routerto)src/router/index.ts(added async session check and routes for/techtreeand/chat/:id?)src/stores/statestore.ts(addedsubjects,subjectsError,fetchSubjectsandcreateSubject)New dependencies
@vue-flow/core(interactive node-graph canvas, pan/zoom controls and custom node rendering)@janishutz/oidc-login-sdk-browserfrom^1.7.0to^1.7.1(uppercasePATCHfix)AI usage declaration
AI was used to