Skip to content

handle_server_error: don't stash a pointer into the freed message #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
millert merged 1 commit into from
Oct 27, 2026
Merged

handle_server_error: don't stash a pointer into the freed message #584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions logsrvd/logsrvd_relay.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,8 +650,12 @@ handle_server_error(const char *errmsg, struct connection_closure *closure)
sudo_ev_del(closure->evbase, closure->relay_closure->read_ev);
sudo_ev_del(closure->evbase, closure->relay_closure->write_ev);

/* Error message from relay could be missing. */
closure->errstr = *errmsg ? errmsg : "unknown error";
/*
* The caller frees the ServerMessage that errmsg points into before
* closure->errstr is used, so store a static string instead of errmsg
* itself. The relay's message is logged above.
*/
closure->errstr = _("error received from relay host");

debug_return_bool(false);
}
Expand Down
Loading