Skip to content

running_as_user: don't skip authentication when a chroot is set #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
millert merged 1 commit into from
Oct 29, 2026
+5 −3
Merged

running_as_user: don't skip authentication when a chroot is set #588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions plugins/sudoers/check.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ get_authpw(struct sudoers_context *ctx, unsigned int mode)

/*
* Returns true if the user is running the command as themselves
* and no SELinux type/role, AppArmor profile or Solaris privilege
* was specified.
* and no SELinux type/role, AppArmor profile, Solaris privilege
* or root directory was specified.
*/
static bool
running_as_user(struct sudoers_context *ctx)
Expand All @@ -93,7 +93,9 @@ running_as_user(struct sudoers_context *ctx)
user_in_group(ctx->user.pw, ctx->runas.gr->gr_name)) &&
ctx->runas.role == NULL && ctx->runas.type == NULL &&
ctx->runas.apparmor_profile == NULL &&
ctx->runas.privs == NULL && ctx->runas.limitprivs == NULL;
ctx->runas.privs == NULL && ctx->runas.limitprivs == NULL &&
ctx->runas.chroot == NULL &&
(def_runchroot == NULL || strcmp(def_runchroot, "*") == 0);
}

/*
Expand Down
Loading