Skip to content

running_as_user: compare the runas group by gid, not by name #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iefa-m wants to merge 1 commit into
base: main
Choose a base branch
from
+31 −4
Open

running_as_user: compare the runas group by gid, not by name #592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions plugins/sudoers/check.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,42 @@ get_authpw(struct sudoers_context *ctx, unsigned int mode)
}

/*
* Returns true if the user is running the command as themselves
* and no SELinux type/role, AppArmor profile, Solaris privilege
* or root directory was specified.
* Returns true if gid is the user's primary group-ID or one of
* the user's supplementary group-IDs.
*/
static bool
user_has_gid(const struct passwd *pw, gid_t gid)
{
struct gid_list *gidlist;
bool matched = false;
int i;
debug_decl(user_has_gid, SUDOERS_DEBUG_AUTH);

if (gid == pw->pw_gid)
debug_return_bool(true);
if ((gidlist = sudo_get_gidlist(pw, ENTRY_TYPE_ANY)) != NULL) {
for (i = 0; i < gidlist->ngids; i++) {
if (gidlist->gids[i] == gid) {
matched = true;
break;
}
}
sudo_gidlist_delref(gidlist);
}
debug_return_bool(matched);
}

/*
* Returns true if the user is running the command as themselves,
* with one of their own groups, and no SELinux type/role, AppArmor
* profile, Solaris privilege or root directory was specified.
* The runas group is compared by group-ID, not by name.
*/
static bool
running_as_user(struct sudoers_context *ctx)
{
return ctx->user.uid == ctx->runas.pw->pw_uid && (ctx->runas.gr == NULL ||
user_in_group(ctx->user.pw, ctx->runas.gr->gr_name)) &&
user_has_gid(ctx->user.pw, ctx->runas.gr->gr_gid)) &&
ctx->runas.role == NULL && ctx->runas.type == NULL &&
ctx->runas.apparmor_profile == NULL &&
ctx->runas.privs == NULL && ctx->runas.limitprivs == NULL &&
Expand Down
Loading