Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
exec_monitor.c, replacedtcgetpgrp()withgetpgid(mc->cmnd_pid)inmon_handle_sigchld.tcgetpgrp()returns the orphaned pgrp when the child sets a new one and stops on SIGTTIN.exec_pty.c, madepty_cleanupunconditionally callsudo_term_restoreifSFD_USERTTYis valid. Fixes a race where the tty was left in raw mode if the process wasn't in the foreground.exec_pty.c, useterm_raw_flagsfor the user tty. ClearedOPOSTmanually on the pty leader so\rworks, avoiding clobbering the saved user tty state.Tested on Linux (Artix, x86_64) with
zsh,pv, and background/foreground transitions. Needs BSD/macOS testing for #583.