Repository navigation
fix(footer): hide footer together with the input window - #564
Merged
Merged
Conversation
The footer kept rendering its status bar whenever the input window was hidden — in the near-fullscreen layout it floats mid-screen over the output content. All input-hide paths (manual toggle, WinLeave auto_hide, dialog hold_input, child_readonly) converge on input_window._hide/_show, so sync footer visibility there using the float hide key, re-anchoring and re-rendering on restore.
Collaborator
Author
jensenojs
marked this pull request as ready for review
November 11, 2026 11:08
Collaborator
Author
|
CI note: the |
Collaborator
Author
|
Update: root-caused the nightly failure to a stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem
When the input window is hidden, the footer float kept rendering its status bar. In the near-fullscreen float layout the footer then floats mid-screen over the output content instead of staying attached to the (hidden) input area.
Cause
All input-hide paths (manual toggle,
WinLeaveauto_hide, dialoghold_input,child_readonly) converge oninput_window._hide/_show, but footer visibility was never synced there — the footer only follows the output window.Change
footer.set_visible(visible): sets the floathidekey without unmounting the window, and re-anchors viaupdate_windowon restore (the output window may have resized while the footer was hidden).input_window._hide(hide) and both branches ofinput_window._show(restore).Notes
Tested:
make test-unit TEST=tests/unit/input_window_spec.lua(30/30),stylua --checkandmake typecheckclean on the changed files.