Skip to content

fix(footer): hide footer together with the input window - #564

Merged
jensenojs merged 1 commit into
sudo-tee:mainfrom
jensenojs:fix/footer-follows-input-hide
Nov 11, 2026
Merged

jensenojs merged 1 commit into
sudo-tee:mainfrom
jensenojs:fix/footer-follows-input-hide

Conversation

@jensenojs

Copy link
Copy Markdown
Collaborator

Problem

When the input window is hidden, the footer float kept rendering its status bar. In the near-fullscreen float layout the footer then floats mid-screen over the output content instead of staying attached to the (hidden) input area.

Cause

All input-hide paths (manual toggle, WinLeave auto_hide, dialog hold_input, child_readonly) converge on input_window._hide/_show, but footer visibility was never synced there — the footer only follows the output window.

Change

  • Add footer.set_visible(visible): sets the float hide key without unmounting the window, and re-anchors via update_window on restore (the output window may have resized while the footer was hidden).
  • Call it from input_window._hide (hide) and both branches of input_window._show (restore).
  • Add a unit test covering hide → show restore behavior.

Notes

  • Before/after capture pending — will attach a short recording of toggling the input window in the float layout.

Tested: make test-unit TEST=tests/unit/input_window_spec.lua (30/30), stylua --check and make typecheck clean on the changed files.

The footer kept rendering its status bar whenever the input window was
hidden — in the near-fullscreen layout it floats mid-screen over the
output content. All input-hide paths (manual toggle, WinLeave
auto_hide, dialog hold_input, child_readonly) converge on
input_window._hide/_show, so sync footer visibility there using the
float hide key, re-anchoring and re-rendering on restore.
@jensenojs

Copy link
Copy Markdown
Collaborator Author

before

图片

after

图片

@jensenojs
jensenojs marked this pull request as ready for review November 11, 2026 11:08
@jensenojs

Copy link
Copy Markdown
Collaborator Author

CI note: the nightly job failure (output_window.is_at_bottom reports the actual visible bottom line in wrapped windows) is pre-existing on current neovim nightly and reproduces on unmodified main (verified locally with NVIM v0.13.0-dev-2081: the same test fails on upstream/main without this change). The other matrix jobs (v0.10.3, v0.11.4, typecheck, lint, architecture, event-contract) pass.

@jensenojs
jensenojs merged commit 8afe833 into sudo-tee:main Nov 11, 2026
11 of 16 checks passed
@jensenojs

Copy link
Copy Markdown
Collaborator Author

Update: root-caused the nightly failure to a stale line('w$') read in the test itself (behavior change from neovim/neovim#37047). Fix PR: #565.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant