Labels with dots#6
Open
KoalaMauve wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was playing around and testing edge cases, and found that labels with dots inside weren't being detected.
They're edge cases and not recommended, but still valid and usable (GNU / LLVM compatible).
As shown below, for the valid label
label.with.dots:,label.withwasn't detected as a label but as regular source code.Only
.dots:appeared as a label. It's caused by the regexp only allowing dots at the beginning (non-exportable labels convention).I've modified the regexp to fix this, allowing dots inside labels. The whole
label.with.dots:is now detected:To make this case easy to test, I've also added an example file with various labels.