Open
Conversation
Since we are bumping DbConnection, needed an appup for it and some adjustments in our soft deployment generation.
v0idpwn
commented
May 5, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
v0idpwn
commented
May 6, 2026
| # If appups directory exist, don't run the task to generate, and instead | ||
| # use the existing appups. | ||
| # Copy any hand-written appups from relups/<from>-<vsn>/appups/, then | ||
| # generate the supavisor appup if it isn't among them. |
Member
Author
There was a problem hiding this comment.
Should be easier to maintain. Previous impl required the supavisor appup to be written if any other appup was.
v0idpwn
commented
May 6, 2026
| @@ -0,0 +1,110 @@ | |||
| defmodule Supavisor.HotUpgrade.DbConnectionMigration do | |||
Member
Author
There was a problem hiding this comment.
Needed to hand roll the migration as there's no code_change implemented.
deepthi
reviewed
May 6, 2026
Member
Author
|
We don't have production deployments of v2.9.3 |
mentels
approved these changes
May 6, 2026
Comment on lines
+30
to
+31
| other -> | ||
| other |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are bumping DbConnection, needed an appup for it and some
adjustments in our soft deployment generation.