Skip to content

fix: skill prompt covers both .graph and three-file formats#121

Closed
jonathanpopham wants to merge 1 commit intosupermodeltools:mainfrom
jonathanpopham:fix/skill-all-formats
Closed

fix: skill prompt covers both .graph and three-file formats#121
jonathanpopham wants to merge 1 commit intosupermodeltools:mainfrom
jonathanpopham:fix/skill-all-formats

Conversation

@jonathanpopham
Copy link
Copy Markdown
Contributor

@jonathanpopham jonathanpopham commented Apr 13, 2026

The skill prompt only mentioned .calls/.deps/.impact files. Users running without --three-file get single .graph files and the prompt didn't tell the agent about them.

Now covers both formats with a note that three-file is recommended.

Summary by CodeRabbit

  • Documentation
    • Updated help text describing support for multiple graph file formats, including both single-file and distributed layouts. Navigation guidance adjusted to reflect available file format options.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

The PR updates the help text for a skill command to document two different ways graph-shard data can be organized: either as a single .graph.* file with internal sections, or as three separate files. The instructions now prioritize the three-file approach but gracefully fall back to the single file.

Changes

Cohort / File(s) Summary
Graph-shard Documentation
cmd/skill.go
Updated skillPrompt string to describe dual support for single-file (.graph.* with [deps], [calls], [impact] sections) and three-file (.calls.*, .deps.*, .impact.*) layouts, with preference logic favoring the three-file format when available.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • greynewell

Poem

📋 Two formats, one command,
Shards unified or single-banded,
Flexibility takes the stand,
Your data flows as you've planned! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks the required template structure with sections for What, Why, and Test plan; it only provides informal context without the checkbox items specified. Restructure the description to follow the template: add clear 'What', 'Why', and 'Test plan' sections with checkboxes for make test, make lint, and manual testing steps.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating the skill prompt to cover both .graph and three-file formats.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonathanpopham
Copy link
Copy Markdown
Contributor Author

Superseded by #122 (full revert). Skill command needs redesign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant