Repository navigation
Add workflow to verify CMakeLists.txt files - #896
Merged
Merged
Conversation
natecook1000
force-pushed
the
verify-runtimes-cmakelists
branch
from
October 8, 2026 15:46
88972be to
522a2ec
Compare
The _StringProcessing and _RegexParser modules are built as a part of the standard library using CMakeLists.txt files in the swiftlang/swift repository, so files added in this project will break that build if the configuration is not updated in concert. This new workflow should help flag that issue before merging - it both verifies that the local versions of the CMake configuration files are in sync with their swiftlang/swift counterparts and completes a CMake build to test that the configuration is up to date with the libraries' current code. Note that for changes that require a CMakeLists.txt update, this job will still error - cross-repository testing from the Swift project should be used to validate that things are actually set up properly.
natecook1000
force-pushed
the
verify-runtimes-cmakelists
branch
from
October 8, 2026 17:02
522a2ec to
e6a9011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_StringProcessingand_RegexParsermodules are built as a part of the standard library using CMakeLists.txt files in the swiftlang/swift repository, so files added in this project will break that build if the configuration is not updated in concert. This new workflow should help flag that issue before merging - it both verifies that the local versions of the CMake configuration files are in sync with their swiftlang/swift counterparts and completes a CMake build to test that the configuration is up to date with the libraries' current code.Note that for changes that require a CMakeLists.txt update, this job will still error — cross-repository testing from the Swift project should be used to validate that things are actually set up properly.