Repository navigation
Evaluate the reaction rates once per output row of the selections - #1413
Closed
luciansmith wants to merge 1 commit into
Closed
luciansmith wants to merge 1 commit into
luciansmith wants to merge 1 commit into
Conversation
Selecting a reaction rate evaluated all reaction rates of the model for that one value, so an output row with the reaction rates selected was quadratic in the number of reactions. getSelectedValues evaluates them once per row and reads the selected rates from them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a reaction rate evaluated all reaction rates of the model for that one value, so an output row with the reaction rates selected was quadratic in the number of reactions. getSelectedValues evaluates them once per row and reads the selected rates from them.
Pulling this from @matthiaskoenig so we can make further changes (other elements could use the same speedup; steady state selections are still slow).