Repository navigation
Update defaults, including switch to LLJIT. - #1439
Open
luciansmith wants to merge 3 commits into
Open
luciansmith wants to merge 3 commits into
luciansmith wants to merge 3 commits into
Conversation
Several related fixes: * The default JIT level is now actually LLJIT (fixing #1419) * The default LLJIT optimization level is now NONE. * The default LLJIT 'numthreads' is now 0. * New 'resetDefaults' function. * Model caching now includes JIT level, LLJIT optimization, and whether conserved moieties are on or off, because those drastically change the compiled model. * Comments for values that were binary being written as if they were hex: '0x00010' is changed to '0b00010' to use the official binary notation instead of the official hex notation. This commit also includes some timing tests, which are here temporarily; they won't need to be run on all platforms every time, but I would like to see the results once, to make sure these defaults are actually the best over all platforms.
We've confirmed that the timing on all platforms is the same as on my Windows machine. (Also, fix a compilation warning in Matrix.h)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several related fixes: