Fix bug with counting utf-8 character lengths.#49
Open
benburkhart1 wants to merge 1 commit intoszatmary:developfrom
Open
Fix bug with counting utf-8 character lengths.#49benburkhart1 wants to merge 1 commit intoszatmary:developfrom
benburkhart1 wants to merge 1 commit intoszatmary:developfrom
Conversation
|
This also appears to resolve my issues in #50 ! |
|
LGTM !! |
|
While it may fix the issue, this change duplicates I'd propose something much simpler: size_t utf8_line_length(const utf8_char_t* data)
{
size_t n, len = 0;
while (0 != data[len]) {
if (0 < (n = _utf8_newline(data + len))) {
return len + n;
}
len += utf8_char_length(data + len);
}
return len;
} |
b0eab5f to
8662e99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the issue in:
#46