Repository navigation
Conversation
Absolutely positioned descendants of the content area, such as the hidden inputs Select and Combobox render, were positioned against SidebarInset and stretched the sidebar wrapper far past the window. The wrapper is overflow-hidden, which still allows anchor jumps, scrollIntoView and focus to scroll it, so the header and sidebar shifted out of place. - The content scroll container is now `position: relative`, so those descendants scroll with the content. - The wrapper uses `overflow: clip`, which cannot be scrolled at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Code Metrics Report
Details | | main (923933d) | #706 (1db37f0) | +/- |
|---------------------|----------------|----------------|-------|
| Coverage | 62.9% | 62.9% | 0.0% |
| Files | 294 | 294 | 0 |
| Lines | 13483 | 13483 | 0 |
| Covered | 8485 | 8485 | 0 |
+ | Test Execution Time | 4m3s | 2m54s | -1m9s |Code coverage of files in pull request scope (91.3% → 91.3%)
Reported by octocov |
itsprade
marked this pull request as draft
November 10, 2026 15:23
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The review reports no active issues with the change to keep AppShell scrolling confined to page content.
No open issues 🎉
What changed in this PR
This PR keeps the AppShell frame stationary during anchor jumps, scrollIntoView, and focus changes, leaving scrolling within the page content.
Changes:
- Replace the frame’s
overflow: hiddenwithoverflow: clipto prevent programmatic scrolling. - Position the content scroller relatively so absolute descendants remain contained.
- Add regression assertions for both CSS classes and a patch changeset.
| File | Description |
|---|---|
packages/core/src/components/sidebar/sidebar-layout.test.tsx |
Assert frame clipping and relative content positioning. |
packages/core/src/components/sidebar/primitives.tsx |
Prevent frame scrolling with overflow-clip. |
packages/core/src/components/sidebar/content-container.tsx |
Make the content scroller the positioning container for absolute descendants. |
.changeset/shell-frame-stays-put.md |
Document the scrolling fix for a patch release. |
Review effort: Balanced
IzumiSy
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Long pages could shift the whole AppShell up: the top bar slid off screen, the sidebar moved out of line, and the page looked cut off at the bottom. It happened on any page with several
SelectorComboboxfields when something jumped to a point off screen, such as an in-page#anchorlink,scrollIntoView, focusing a field below the fold, or a form moving focus to its first invalid field.Why it happened
SelectandComboboxrender absolutely positioned hidden inputs for form submission. Their positioning box wasSidebarInset, not the content scroll area, so on a long form they stretched the shell's outer frame (sidebar-wrapper) far past the window. On one demo page the frame was about 6,900px tall in a 768px window.overflow: hidden, which hides the extra height but can still be scrolled programmatically. Anchor jumps,scrollIntoViewand focus scroll every scrollable ancestor, so they scrolled the frame itself.Fix
[data-appshell-scroll-container]) is nowposition: relative, so absolutely positioned content scrolls with the page instead of stretching the frame.overflow: clipinstead ofoverflow: hidden, so nothing can scroll it. The two look identical.Testing
sidebar-layout.test.tsxcover both classes.scrollIntoViewand anchor jumps scroll only the content.fillpage lays out as before.Patch changeset included. This PR is independent of the forms PRs and can merge on its own.
🤖 Generated with Claude Code