Repository navigation
Conversation
IzumiSy
force-pushed
the
feat/line-items-2427
branch
from
November 11, 2026 03:15
7bcf578 to
f627936
Compare
Contributor
Code Metrics Report
Details | | main (e2240e3) | #710 (23c8131) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 90.3% | 90.3% | 0.0% |
| Files | 284 | 284 | 0 |
| Lines | 8333 | 8333 | 0 |
| Covered | 7529 | 7529 | 0 |
+ | Test Execution Time | 3m41s | 2m48s | -53s |Reported by octocov |
) * refactor(table-core): extract neutral value renderers * feat(line-items): add internal readonly display * feat(line-items): add document commands and manual ordering (#679) * feat(line-items): add internal readonly display * feat(line-items): add document state and manual ordering * docs(line-items): clarify the document store contract * refactor(line-items): separate document model and store concerns * feat(line-items): expose reorderable table and showcase * feat(examples): demonstrate line-item row commands * Fix document drift * fix(line-items): move example actions below the table * refactor(line-items): group document model and types * Move function * refactor(line-items): remove reorder announcements * fix(line-items): make document identity types explicit * fix(line-items): preserve stable client keys in row interactions
* feat(line-items): add cell editing with shared table core * feat(line-items): configure column widths and enable editable showcase * feat(line-items): add date and readonly modes to showcase * feat(line-items): demonstrate validation and computed totals * refactor(data-table): import shared table helpers directly * test(table-core): colocate input value helper coverage * perf(line-items): cache row lookups by document snapshot * fix(line-items): preserve links in readonly editable cells * refactor(line-items): drop live editor replacement handling * refactor(table-core): separate cell presentation from editor controls * refactor(line-items): separate column validation from reconciliation * refactor(table-core): inject editors and prepare renderers by column * refactor(line-items): derive editor contracts and dispatch from adapters * test(line-items): align editing fixture with optional identity * refactor(table-core): bind display and editor dependencies in adapters * refactor(table-core): colocate date-time draft with date editor * refactor(line-items): make headless editor definitions the source of truth * refactor(line-items): group editor settings under editorOptions * fix(line-items): retain cell sessions when rebinding columns * test(table-core): colocate cell editing session hook tests * feat(line-items): unify renderers and expose calendar restrictions * fix(showcase): use an icon button for line item deletion * fix(line-items): remove drag handle column padding * refactor(table-core): align display adapter contracts * refactor(data-table): remove date-time draft compatibility exports * feat(line-items): add column presentation props * fix(line-items): retain editing handle across copied hook values * fix(data-table): restore DateTimeDraft type exports * fix(line-items): present retained drafts and remember error dismissal * fix(line-items): correlate fixed choices with property enums * fix(line-items): preserve raw values for typed choice displays * fix(line-items): reject current edits refused during adoption * feat(line-items): define property-safe clear value policies * fix(line-items): always check confirmed values before adoption * fix(table-core): separate error messages from accessible hints * fix(line-items): make badge label ownership exclusive * fix(line-items): align readonly cells in icon-bearing columns * fix(line-items): normalize choice label lookup consistently * fix(line-items): call custom renderers with only their row * fix(showcase): display fractional line item quantities * fix(line-items): keep editing handles opaque in public declarations * fix(showcase): use consumer utilities for line item styling * fix(line-items): reduce draft status noise while typing * docs(data-table): restore DateTimeDraft export documentation
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # docs-manifest.json Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Contributor
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # docs-manifest.json Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Transactional documents need a reusable line editor with consistent local editing and net change tracking, rather than a separate implementation in each application. Consumers should retain ownership of domain rules, document-wide validation, data loading, and persistence.
This is the integration feature PR for the initial LineItems milestone, targeting
main. Requirements: platform-planning #2427. The issue's scope takes precedence over earlier LineItems explorations.Summary
Included PRs
Initial milestone coverage
Copied from platform-planning #2427 and assessed against
5915625(the current PR head). Requirement wording and nested acceptance criteria are preserved; the added Coverage bullets describe this branch rather than changing the source requirements. The issue's scope boundaries remain authoritative.11 / 43 implemented; 17 partial; 15 not implemented. Partial requirements stay unchecked. A checked standalone requirement does not imply that the entire save/changeset flow is complete. In particular,
isDirtyis not a consumer-readable changeset.Primary implementation evidence: public hook contract, document model/baseline, cell commit/validation, closed editor catalog, ordering UI, and numeric blur behavior.
Assessment validation: focused LineItems/shared-table-core tests passed (33 files, 413 tests; no reported type errors) locally at
9556c1f. The subsequent merge into PR head5915625changes documentation/docs tooling only, not package or showcase implementation. Browser/device interactions, the full repository suite, and an end-to-end save flow were not run. This is an implementation-coverage audit, not a claim that every acceptance scenario has a dedicated test.Remaining feature areas
1. Display and Cell Editing
LI-01 Display application-defined line-item fields and calculated values in a table, without procurement, sales, or other domain-specific assumptions.
LI-02 Support text, number, fixed-choice, and date editing. Text editing includes free-form fields such as notes.
LI-03 Support boolean editing.
LI-32 Support consumer-provided custom cell editors.
LI-33 Support server-backed option lookup when selecting a value within an existing line.
LI-34 Integrate custom editors with the same commit, validation, editability, save preparation, and change-tracking rules as built-in editors.
LI-05 Reject invalid cell input, preserve the rejected input, show validation feedback, and allow correction and retry.
LI-35 Keep a server-backed selector's search query separate from its committed cell value.
2. Local Editing, Equality, and Permissions
LI-04 Let consumers add and remove lines, reflecting those operations in the local document and its change tracking.
LI-06 Discard unsaved field edits, additions, removals, and order changes, restoring the saved baseline. Discard pending cell drafts as part of this operation.
LI-11 Allow consumers to provide custom equality logic at the column level.
LI-26 Support consumer-supplied currency- and unit-of-measure-specific decimal precision constraints.
LI-14 Let consumers provide predicates controlling column editability, sorting, and actions.
LI-07 Allow consumers to compose readonly, editable, and restricted-editing views through those controls. Keep locked fields visible for reference rather than hiding them solely because they cannot be edited.
3. Existing-Line Filtering
searchproperty; the detailed signature remains unspecified.4. Selection and Consumer-Defined Actions
LI-21 Support optional multi-row selection and consumer-defined bulk updates.
LI-22 Support consumer-defined deletion of multiple selected rows. Let consumers enable or disable bulk operations according to their workflow.
LI-36 Deselect rows that no longer match the active filter. Bulk operations apply only to the remaining selected rows.
LI-37 Select all items in the current result set, not just rows currently rendered or inside the viewport.
LI-38 Let consumers define the behavior of actions on selected rows.
5. Document Order
LI-17 Support manual reordering through dragging and keyboard controls.
LI-19 Support consumer-defined business sorting, including ordering that differs from alphabetical labels, such as
XS → S → M → L.LI-39 Treat sorting and manual reordering as operations on the same document order.
LI-40 Disable sorting and manual reordering while a search query is active.
LI-18 Make the final document order available for persistence and restoration, including the placement of newly added lines.
6. Changeset Inspection
LI-08 Make additions, field updates, removals, and order changes available to the consumer as distinct changes. Exclude unchanged lines, unchanged fields, and empty updates.
LI-09 Distinguish an untouched field from an explicitly cleared value when reporting changes.
LI-10 Report no field change when the user only focuses a cell, re-enters an equivalent value, or restores the original value. Let consumers skip unnecessary line persistence when there are no net line changes.
LI-41 Expose current changes independently of any save action, using committed cell values only.
LI-42 Make the complete consumer-provided data available for added lines, including readonly and non-displayed fields. The consumer selects and maps the data needed for persistence.
LI-43 Produce the net difference between the saved baseline and current committed state, rather than an operation history.
10 → 20 → 30reports only the change to30.10 → 20 → 10reports no change.LI-44 Treat notes and other editable fields under the same change-tracking rules. LineItems does not assign them an independent persistence lifecycle; the consumer decides how to handle their changes.
7. Save Preparation and Save Results
LI-30 Confirm and validate pending cell edits before saving.
LI-31 Prevent user changes to line items while a document save is in progress.
LI-12 Let the consumer replace the full line collection with confirmed data after a successful save.
LI-13 Transition newly saved lines from temporary client identity to their confirmed server identity through the full-collection replacement.
LI-45 On a failed save, retain unsaved changes and the existing saved baseline. Allow the user to edit and retry.
LI-46 Keep persistence timing, transport, mutation mapping, and result handling in the consumer. Neither changeset inspection nor local editing automatically performs backend persistence.
8. Document-Level Composition
LI-23 Let consumers combine line changes with header changes for a document-level save. Header state, cross-field business rules, transaction execution, and backend validation remain consumer/backend responsibilities.
LI-24 Let consumers compose multiple LineItems instances under one document, such as debits and credits or components and operations.
9. Data Ownership and Scale
LI-47 Keep the full consumer-provided line collection in memory. The consumer obtains the complete collection before providing it to LineItems.
LI-25 Never interpret filtering or the absence of rendered rows as deletion. Preserve values and pending changes for hidden rows and include their committed changes in changeset inspection.
LI-48 Do not impose a fixed maximum line count. Revisit data-volume and rendering optimizations when practical usage demonstrates a need.
No fixed performance guarantee at 500 or 10,000 rows is part of the initial acceptance criteria. The absence of a row-count cap does not imply guaranteed performance for arbitrarily large documents.