Repository navigation
Conversation
added 2 commits
November 16, 2026 09:54
…ones Below `md` the GlobalHeader hides the app title and its divider, and DynamicBreadcrumb shows only the current page when the trail is three or more segments deep. The breadcrumb list no longer wraps; a long page title truncates with an ellipsis, and each link is 24px tall (WCAG 2.5.8). Part of tailor-inc/platform-planning#2207 (Phase 2).
Contributor
Code Metrics Report
Details | | main (e4b5616) | #736 (4dabdb5) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 62.9% | 62.9% | -0.1% |
| Files | 294 | 294 | 0 |
| Lines | 13513 | 13517 | +4 |
+ | Covered | 8505 | 8507 | +2 |
+ | Test Execution Time | 4m29s | 4m11s | -18s |Code coverage of files in pull request scope (48.0% → 48.0%, patch 100.0%)
Reported by octocov |
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> # Conflicts: # docs-manifest.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the mobile umbrella tailor-inc/platform-planning#2207 (Phase 2, "In
GlobalHeaderLayout, the page title takes the space and the breadcrumb is only 15 to 30 px wide at 375 to 390 px").In
GlobalHeaderLayout.DefaultHeaderthe app title isshrink-0and the breadcrumb wrapper ismin-w-0 flex-1. At 375 px the title (171 px in the example) and the actions leave the breadcrumb 15 px. The list isflex-wrap, so the trail breaks into one or two characters per row and overflows the 56 px header into the content.SidebarLayout.DefaultHeaderhas no title, but its breadcrumb wraps the same way once the trail needs more than about 170 px.Changes
GlobalHeader: the title and its divider getmax-md:hidden. Below 768 px the breadcrumb has the whole left side. Cloudscape's top navigation does the same: the application name is removed on smaller screens.DynamicBreadcrumb: when the trail has three or more segments, the ancestors getmax-md:hidden, so phones show only the current page. Two-level trails keep both segments. This is a class on the existing wrapper, decided at render time fromsegments.length; no effect, observer or measurement.BreadcrumbListisflex-nowrap(Carbon: "Breadcrumbs should never wrap onto a second line").BreadcrumbItem,BreadcrumbLinkandBreadcrumbPagegetmin-w-0 truncate, so a long title ellipsizes instead of pushing the trail out of the header. The separator isshrink-0.BreadcrumbLinkandBreadcrumbPagegetpy-0.5: the link is 24 px tall (WCAG 2.5.8 target size) around the unchanged 20 px line. The header stays 56 px.Behavior change at 768 px and wider: a trail that does not fit no longer wraps; its items shrink and truncate with an ellipsis.
Results
Measured with Playwright (Chrome, touch emulation, device scale 2) on the vite example, whose header has three action buttons (124 px). Depth 1 to 4 are
/dashboard,/dashboard/orders,/dashboard/orders/ord-1001and/dashboard/orders/ord-1001/activity.Before, at 375 px the trail occupied y = −31 to 87 px of a 56 px header (
shots/state2_phone375_header_dashboard_orders_ord-1001_activity.pngin pr-a/before). After, every link is 24 px tall and sits inside the header.Screenshots
375 px, depth 4: before (
main) and after.(pr-a/before/state2_phone375_header_dashboard_orders_ord-1001_activity.png, pr-a/after/state2_phone375_header_dashboard_orders_ord-1001_activity.png)
375 px, depth 2: both segments stay.
(pr-a/after/state2_phone375_header_dashboard_orders.png)
768 px, depth 4: unchanged except the 24 px links.
(pr-a/after/state2_tablet768_header_dashboard_orders_ord-1001_activity.png)
Checks
pnpm fmt,type-check,lint,test(3,092 core tests after mergingmainatc90cdf6),docs:syncanddocs:checkpass.check-dtsnot run (no declaration changes).global-header-layout.test.tsx: a three-level route marks the title and the two ancestors with the responsive class and leaves the current page visible; a two-level route marks nothing; the list isflex-nowrapand the link has the 24 px padding. happy-dom has no layout, so the tests check the classes, and the widths above come from the Playwright run.Not in this PR
SidebarLayoutmeasurements: the example app usesGlobalHeaderLayoutonly. The breadcrumb change applies to both headers.🤖 Generated with Claude Code