Repository navigation
Conversation
added 2 commits
November 18, 2026 20:58
Below a 480px footer, hide the page-size switcher, shorten the page text to 1/5 and the selection count to 3/240 selected (full text kept for screen readers), and shrink the page buttons to 28px. With rows selected the footer takes two lines at 375px instead of three (four in Japanese). English row counts use row or rows instead of row(s).
Contributor
Code Metrics Report
Details | | main (e4b5616) | #742 (2d6b2ba) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 62.9% | 62.9% | +0.0% |
| Files | 294 | 294 | 0 |
| Lines | 13513 | 13525 | +12 |
+ | Covered | 8505 | 8513 | +8 |
+ | Test Execution Time | 4m29s | 3m33s | -56s |Code coverage of files in pull request scope (10.4% → 10.6%, patch 93.3%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #685, based on the review comments there. Part of the mobile umbrella tailor-inc/platform-planning#2207.
After #685, the footer still takes three lines at 375 px when rows are selected, and four lines in Japanese. This PR makes the footer more compact when the footer is narrower than 480 px. With rows selected, it now takes two lines at 375 px. Without a selection, it takes one line.
Changes
Below 480 px (the same
data-table-footercontainer query as #685):DataTable.Paginationhides the page-size switcher, as MUI does.DataTable.Pagination. Japanese: "2/240 行を選択中". Screen readers still get the full text, and the live region still announces the full text.At all widths:
Nothing else changes at 480 px or wider.
From the review suggestions, this PR does not take these:
How to reproduce
/showcase/data-table-selection.Results
Measured with Playwright (Chrome, device scale 2) on
/showcase/data-table-selection, at 375 px.Screenshots
Checks
vitest run src/components/data-table: 833 passed. New tests cover the short and full texts (classes andaria-hidden), the singular and plural forms, and the Japanese short text.docs:check.docs-srcand synced. Patch changeset added.🤖 Generated with Claude Code