Skip to content

Attribute REPL entries and fresh test fixtures - #1360

Merged
taras merged 1 commit into
mainfrom
codex/1171-repl-entries-and-fixtures
Nov 17, 2026
Merged

taras merged 1 commit into
mainfrom
codex/1171-repl-entries-and-fixtures

Conversation

@taras

@taras taras commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Why

REPL history and lifecycle failures need the journal for the entry exercised by the test. Fresh Core, Git, Testing and Workflow tests also need their journal through the assertions that can fail after execution. Advances #1171 and builds on #1359.

What changes

  • Share a test fixture helper for one admitted REPL entry. It captures that guarded entry and leaves earlier entries with the history fixture.
  • Attribute fresh Core, Git, Testing and Workflow case journals through the shared failure-only path.
  • Keep the cumulative Git no-subcommands assertion inside each guarded refusal capture, preserving the original final assertion.

Review guide

Start with packages/cli/tests/fixtures/repl/failure-journal.ts and the existing REPL failure witness. The last signed commit addresses the independent review finding in Git observation case GO11.

How to verify it

  • The REPL history and lifecycle suites passed on Deno, Node 22.23.4, and Bun 1.4.0. The retained witness exercises the artifact identity and passing runs produced no automatic files.
  • The GO11 before-and-after probe triggers the same late assertion. The correction saves the journal for the paired-form variant. The passing 50-case Git suite and both typechecks passed.
  • The Planner and independent Astra reviewer passed signed revision dcf590c18. Astra replaced Fable after a quota refusal and verified the original scope and correction.

Scope

This stage accounts for 117 of the historical owner rows. The remaining 120 pending or partial rows are tracked in #1171.

Scope confirmation

  • Every changed file supports failure-only journal attribution or its verification.
  • The description matches the reviewed signed revision and receipts.

taras added a commit that referenced this pull request Nov 17, 2026
taras added a commit that referenced this pull request Nov 17, 2026
taras added a commit that referenced this pull request Nov 17, 2026
@taras
taras added this pull request to stack #1386 November 17, 2026 12:00
taras added a commit that referenced this pull request Nov 17, 2026
taras added a commit that referenced this pull request Nov 17, 2026
Base automatically changed from codex/1171-readonly-subprocess-and-owners to main November 17, 2026 16:09
Replay the reviewed #1360 patch onto squash-merged #1359.
taras added a commit that referenced this pull request Nov 17, 2026
@taras
taras force-pushed the codex/1171-repl-entries-and-fixtures branch from 18eee09 to 6a67566 Compare November 17, 2026 17:11
@taras
taras marked this pull request as ready for review November 17, 2026 17:59
@taras
taras merged commit 4762b32 into main Nov 17, 2026
64 checks passed
@taras
taras deleted the codex/1171-repl-entries-and-fixtures branch November 17, 2026 20:01
taras added a commit that referenced this pull request Nov 17, 2026
* test: attribute failure journals to declaring cases

* test: capture failure journals for Testing document cases

* test: capture failure journals for live WebForm cases

* test: capture failure journals for held Core hosts

* test: retain the ORC12 child journal for parent failures

* test: attribute journals in ordinary Git execution cases

* test: attribute journals in direct Core document cases

* test: attribute failure journals for live synthetic REPL entries

* test: attribute guarded ACP and TestAgent execution journals

* test: attribute safe Agent and nested Testing execution journals

* test: attribute fresh REPL observation entry journals

* test: capture additional direct Core execution journals

* test: attribute fresh workflow observation journals

* test: attribute fresh CLI and Testing execution journals

* test: attribute fresh Git issue scenario journals

* test: retain separate CLI assembly journals for parent failures

* test: attribute guarded CLI host and upgrade journals

* test: attribute guarded Agent provider and usage journals

* test: attribute fresh Answers, Elicit and Fail fixture journals

* test: attribute fresh TestAgent component and launch journals

* test: capture fresh inline REPL selection journals

* test: capture guarded Glob fixture journals

* test: attribute guarded Agent function component journals

* test: retain separate journals for Testing session siblings

* test: capture guarded Core prop evaluation journals

* test: preserve independently bounded subprocess journals

* test: capture additional held host and hook journals

* test: capture guarded root comparisons and eval lifetimes

* test: capture complete Testing activation sessions

* test: attribute guarded exec timeout fixture journals

* test: retain the activation expiry fixture journal

* test: attribute guarded Core document helpers

* test: attribute guarded Agent package execution controls

* test: attribute guarded Git and Workflow host probes

* test: attribute guarded Plan and Upgrade documents

* test: attribute fresh REPL source ownership runs

* test: attribute fresh Git binding and Issue envelopes

* test: attribute fresh Workflow and Testing journals

* test: preserve both workflow inputs in identity comparison

* test: attribute fresh Core execution and comparison owners

* test: attribute joined read-only component subprocess journals

* test: attribute loader comparisons and a fresh REPL refusal

* test: attribute independent Git reconciliation runs

* test: attribute execution init and component fixture journals

* test: capture Testing activation and Workflow observation cases

* test: capture Git observation and owned-effect fixtures

* test: capture fresh REPL history head entries

* test: attribute contextual cwd and validation comparison journals

* test: capture fresh REPL lifecycle entries

* test: complete guarded binding and failure fixture coverage

* Attribute filesystem and generated document test failures

* Attribute inline roots and fresh CLI TODO executions

* Attribute single-entry REPL lifecycle checks

* Attribute REPL component lookup executions

* Keep the GO11 Git assertion inside journal capture

* Attribute fresh Core target and protocol executions

* Attribute fresh service and ticket checkout test roots

* Complete capture for mixed Core document fixtures

* Attribute generated selection pairs and recovery guide test

* Attribute ordinary Deno composition test roots

* Adopt shared journals in Core evaluator tests

* Adopt shared journal resource in Each tests

* Use shared failure journal package in evaluator cases

* Migrate Core cases to shared journal resource

* test: adopt shared journal resource in #1356 consumers

* Use package journal entry in Core stream tests

* migrate #1357 ordinary journal cases to shared fixtures

* Migrate compiler boundary cases to shared failure journal

* Use shared journal package imports in #1359 tests

* Use shared journal fixture in testing boundary cases

* Use shared journal fixture for checkpoint case

* Format #1356 shared journal tests

* Migrate eligible journal owners to shared fixtures

* Migrate #1361 journal fixtures to shared support

* Restore #1359 journal ownership for nested tests

* Adopt shared failure journal in PR 1360 suites

* Restore attributed owners in Core journal suites

* fix(core): restore D5 failure journal ownership

* Restore failure journals in PR 1360 cases

* Restore direct it registration in Core held-host tests

* Migrate assert throws journal ownership

* Migrate testing boundary journal owner

* Restore direct test declarations in Agent, REPL and Web

* Migrate testing boundary contract cases

* Migrate test component journal cases

* Migrate use testing journal cases

* Keep ordinary test declarations in two Testing suites

* Migrate workflow generated observation cases

* Remove unused journal case registrar

* Remove unused testing case registrar

* Restore direct it registration in Git tests

* Restore direct Glob and TestAgent test declarations

* Restore direct test declarations in #1358 suites

* Restore direct declarations for held-host cases

* Restore direct Git and Workflow test declarations

* Keep direct Testing declarations in the #1359 overlap

* Restore direct REPL and Cwd test declarations

* Capture REPL entry and fixture failure journals

Replay the reviewed #1360 patch onto squash-merged #1359.

---------

Co-authored-by: Luna <luna@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant