Skip to content

[Journal migration] Capture guarded Core filesystem and component test journals - #1365

Open
taras wants to merge 161 commits into
mainfrom
codex/1171-core-filesystem-and-components
Open

taras wants to merge 161 commits into
mainfrom
codex/1171-core-filesystem-and-components

Conversation

@taras

@taras taras commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Why

Core filesystem and component tests need their execution journals when a later assertion fails. This stage of #1171 applies shared case-attributed capture and keeps independent executions separate. It builds on #1363.

What changes

Eligible ordinary cases use the existing suite journal resource through beforeEach. The migration covers File.Delete refusal cases, File and Files-fatal behavior, fixed filesystem components, registration, returns, invocation identity and output errors. Supplied, private and replay fixtures retain their existing ownership.

The existing CIV26 correction gives both delegation variants fresh streams and asserts their actual refusals. Existing scenarios, expectations, late assertions, deadlines and joined cleanup are preserved.

This restack changes ancestry while preserving the accepted seven-file migration patch byte for byte. Current signed head d414f03ca0e04367a6482310e10a44d0b61bec6f joins the reviewed/tested child 92acb3f5 with actual main 495b1123, containing merged #1363. Its complete tree is identical to 92acb3f5; the original test receipts retain that tested SHA.

Review guide

Start with the File.Delete late-refusal coverage and CIV26. The whitespace-ignored diff helps separate capture changes from reindentation.

How to verify it

  • Focused Deno on tested 92acb3f5: 39 tests and 352 steps passed.
  • Node 22.23.4 and Bun 1.4.0: 339 tests passed under each runtime.
  • Scoped formatting and whitespace checks passed; passing artifact roots were absent.
  • The retained FD5 failure witness for the accepted patch produced four distinct journals and sidecars.
  • The retained Planner and original independent Codex Astra both PASS on exact current d414f03c, reusing the unchanged-tree evidence from 92acb3f5. The Planner verified all 891 expectation expressions and zero registering aliases.

Base and delivery

This PR now targets actual main 495b1123, containing merged #1363. Main-target CI 44313682438, attempt 2 passed on exact d414f03c: 62 successful jobs and one expected skip. All 60 source/runtime results passed in attempt 1; only the main-health gate and dependent aggregate were refreshed after main recovered. Current main is green; ready for maintainer merge.

Scope confirmation

  • Every changed file supports this migration or its verification.
  • Unrelated cleanup is excluded.
  • The mechanical restack preserves the accepted migration patch.
  • The description matches the current source and verification.

taras added 30 commits November 16, 2026 13:22
@taras
taras added this pull request to stack #1386 November 17, 2026 12:00
Replay the reviewed #1363 patch onto current main.
…-97ad98e' into codex/1171-journal-rebase-1365

taras commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Restacked against the maintainer's actual #1363 head 97ad98e41d5636fdee968f9996cafc0fd8e8e24b. Published signed child 92acb3f53ab3b7b0f9c78b4d756938cc8fd7a0aa as a fast-forward from a0c70257, guarded by an exact lease. The seven-file child patch remains byte-for-byte identical to the accepted predecessor: SHA-256 22d3c845b3584a16e92055db4b45b846d6cfe30979cd284391b9a6a1dd2e97d7.

Retained Planner PASS and original independent Codex Astra (gpt-6-astra) PASS on exact 92acb3f5, no blocking findings. Astra receipt SHA-256: 9e8ae0efb1e9b8f0b4cbe8b07e7e7e884c6dfe137c906f45a982d8b9456282cf. The review preserves supplied/private/replay ownership, late assertions, joined cleanup, File.Delete adoption and existing actual-source checks. Original role identities and correction allowances remain unchanged.

Focused verification passed on the exact child: Deno 39 tests/352 steps; Node and Bun 339 tests each; scoped formatting and whitespace checks. Passing artifact roots were absent. This stays a draft depending on #1363; required main-target CI follows its parent's merge and base reconciliation. The parent and all higher branch refs were left intact.

Base automatically changed from codex/1171-agent-testing-git-owners to main November 18, 2026 13:13
@taras
taras marked this pull request as ready for review November 18, 2026 13:14

taras commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Completed the ancestry sync after #1363's squash merge. Signed current d414f03ca0e04367a6482310e10a44d0b61bec6f has parents 92acb3f5 and actual main 495b1123. Its entire source tree is unchanged from tested/reviewed 92acb3f5, and the seven-file effective patch remains byte-identical. The update was published as an exact-lease fast-forward; original test receipts stay attributed to 92acb3f5, without hash-only reruns.

Retained Planner PASS and original independent Codex Astra PASS on exact d414f03c, no findings. Astra receipt SHA-256: c8a96160a777c4d58ca3d7897493b36e3668347073670fb9fa161360da0e967d. Existing case/source attribution, private and replay streams, assertions and joined cleanup are preserved.

Required main-target CI 44313682438, attempt 1 is now running on the correct current base. This is a pending delivery gate; no merge was performed here.

@taras taras changed the title Capture guarded Core filesystem and component test journals [Journal migration] Capture guarded Core filesystem and component test journals Nov 18, 2026

taras commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Ready for maintainer merge: exact signed d414f03ca0e04367a6482310e10a44d0b61bec6f, current green main 495b1123, retained Planner and original Astra PASS.

CI 44313682438, attempt 2 is successful, all 63 jobs accounted for: 62 success and one expected skip. All 60 source/runtime/control jobs passed in attempt 1. Only main-green and the dependent aggregate were refreshed after unchanged main495's single bounded macOS retry passed. No source/runtime tests were rerun by this gate refresh.

The main macOS intermittence is tracked in #1417, which remains open; the health incident #1416 closed automatically. No timeout change or causal-fix claim is made. Your parent rebase was preserved, and no merge was performed here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant