Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Pending replacement and validation. The implementation currently shown at
45840dbad780d33053f1dbd933bb45854d174eedis superseded by the smaller-design work and is not approved for merge. Its existing ACPX changes have not been accepted.Why
An unchanged Claude reconnect must keep the existing native conversation and its actual model, context and effort, even when that model is absent from the offered picker rows.
What changes
The intended fix keeps the selector tied to the actual running model through ordinary ACP rows. Plain and legacy continuation must make zero model, configuration or startup-model writes. Explicit authored use must verify settings on the final native attachment and refuse contradictory acknowledgements. Started Prompt and Sidekick records must report the actual configuration truthfully.
How to verify it
The original Architect froze three linked controlled journeys: unchanged cold continuation, explicit authored use across cold attachments with restore-or-fence, and truthful native started reporting through the existing host actions. The historical smaller candidate failed explicit contradictory acknowledgement and is retained as failure evidence. Current source-owned validation is in progress; no replacement implementation or passing result is claimed yet.
Scope
Prefer the smallest solution using existing ACPX APIs and the XMD/adapter source owners, without changing ACPX. A candidate that changes ACPX does not establish necessity. Any unavoidable change must first identify the precise failing operation, smallest source hunk and alternatives, then obtain upstream source PR and patch-retirement provenance before integration.
Risks and limitations
The current diff includes six ACPX paths and remains historical work pending replacement. Do not treat its vendor/private-RPC approach as the accepted solution. No new source has been pushed for the smaller design. Exact new-head review and required CI will follow a proven implementation. Merge remains with the maintainer.
Closes #1239 when the reviewed replacement is delivered and merged.