Repository navigation
Capture expected CI aggregate errors in workflow tests - #1407
Conversation
|
Independent review: PASS at Reviewer: Codex The reviewer traced every No blocking findings. Applicable retained Deno/Node/Bun evidence covers 51 tests/steps per runtime; focused typecheck and formatting passed. The tested and published commits have identical trees. Local Deno 2.9.7 differs from CI's recorded 2.9.5; hosted checks remain required. Review receipt SHA-256: |
|
All 60 test/build/check jobs passed in run 44227118849, with the normal one-job skip. The only failing prerequisite is #1406 has since merged as |
|
Hosted output verification: Bun 3/10 passed, ran |
runGreen joins the aggregate under scoped Stdio suppression, so the expected `::error::` lines of rejected aggregates stay in the captured result instead of reaching the test process's streams, where a CI runner raises them as annotations. Exit assertions report the captured streams JSON-escaped when they fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The failed health/aggregate checks were refreshed only after current main recovered. Attempt 2 is now successful: 62 jobs passed and one skipped, with unchanged source The repository ruleset additionally requires the branch to be current with main. A mechanical restack onto green main |
|
Mechanical restack published as signed Original Planner: PASS on the new head. The same retained independent Astra reviewer New-head focused Deno verification passed 9 suites/51 steps with zero raw workflow commands. Prior Node/Bun/type/format/control evidence is explicitly inherited, not described as rerun. The newer base changes only the unrelated History wait. Required CI on this exact new head is the remaining delivery gate. |
47ac540 to
7a60d87
Compare
|
Final required CI passed on exact reviewed restack #1402 is also reviewed and green at its existing maintainer head. After the first of these PRs merges, any necessary strict-base refresh of the other will preserve its patch and exact-head review requirements. The final corpus remeasurement for #1409 will follow both merges. |
Why
Passing CI workflow tests emitted GitHub error annotations. Their deliberately rejected aggregate subprocesses forwarded raw workflow commands, so successful jobs appeared to contain CI failures.
What changes
The tests capture expected aggregate stdout/stderr in the complete child result. Unexpected assertion failures still report labeled exit status and escaped full output. Scoped Stdio suppression restores normal forwarding on exit; existing zero/nonzero expectations stay intact.
How to verify it
7a60d872eb0e2ef37963d21b25b272f01ca1ddec, based on main1ce93ad5.::error::commands, confirming the actual output improvement.Scope
Only
scripts/tests/ci-workflow.test.tschanges. This is the separate output follow-up to the completed main repair. Local Deno 2.9.7 differs from CI's recorded 2.9.5.Scope confirmation