Skip to content

Allow explicit Implementor models at joined workflow handoffs - #1411

Open
taras wants to merge 3 commits into
mainfrom
codex/sonnet-selection-1396
Open

taras wants to merge 3 commits into
mainfrom
codex/sonnet-selection-1396

Conversation

@taras

@taras taras commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Why

A workflow caller needs to choose the Implementor model at a joined handoff before that role starts. The previous workflow hardcoded the Claude Implementor model and could not expose that boundary through Entry.Run.

What changes

Before: the workflow always selected its default model, and shell existence checks could mistake an unreadable reservation parent for an unused Implementor.

After: callers can select the Implementor model explicitly, stop after a bounded number of joined steps, and continue the same record. Selection is refused after retained or uncertain Implementor work, including unreadable reservation paths.

How it works

The optional model follows the existing role profile and confirmed Session configuration. A joined continuation captures the user's selection before first dispatch. A local contextual lstat check admits selection only when all five existing reservation locations are confirmed absent.

What must stay true

  • Omitted model selection preserves existing defaults.
  • Continuation preserves original sessions, captured inputs and consumed allowances.
  • Occupied entries, dangling links and observation errors refuse before authorization capture.
  • The actual provider configuration remains established by Session confirmation.

How to verify it

The Implementation suite and standalone unreadable-parent probe passed. The probe verifies refusal and unchanged prior continuation bytes, loaded Ticket state and retained file inventory. LaunchPolicy, ProductionRole and adversarial-session-continuity tests passed, as did focused Deno and Node typing checks.

Planner feedback and independent Codex Astra review returned PASS for exact commit fa09a712c6fc03268a70e3ffb0882cd709fbe8cb. All three original acceptance clauses were examined with no blocking findings. The original failed role attempts and authentic substitute/fallback receipts remain preserved. Exact-head CI and current main CI passed. Native delivery closeout verified the stable published head and returned ready_for_merge with no remaining gates.

The first Node CI run reached the response-correction case when the original test file hit its two-minute deadline. The two new Sonnet cases now run in a separate discovered entry with the same assertions and admission deadline. Both affected Node entries, focused Deno regressions, discovery/deadline checks and typing pass locally.

Scope

Includes explicit Implementor model selection, joined Entry.Run boundaries, same-record continuation and their focused regressions. This does not implement REPL model-picker/reconnect behavior or reconcile another Ticket's historical reply.

Risks and limitations

All delivery gates passed for the exact published head. The externally selected ready state is preserved, and merge remains with the maintainer. The approved Codex correction has its own authentic receipts; the failed Sonnet call, historical results and already consumed correction round remain preserved.

Scope confirmation

  • Every changed file supports the purpose described above.
  • Unrelated cleanup and formatting changes are excluded.
  • No generated dependency output changes are included.
  • This description matches the final diff and verified delivery result.

@taras
taras marked this pull request as ready for review November 18, 2026 09:03
@taras
taras force-pushed the codex/sonnet-selection-1396 branch from 02f226e to 6c6853b Compare November 18, 2026 09:03
taras and others added 2 commits November 18, 2026 04:22
…sarial workflow

Add optional implementationModel to the launch and migration tasks, the
standalone phase request and the Phase.Run/Role/Correct/Profile chain. The
explicit model replaces only the Implementor's default (Claude opus, Codex
policy model); effort, provider and every other role profile are unchanged.
The Ticket manifest records it as roles.implementor.model, and a saved call
profile must agree with it.

Expose maxSteps on run.md and Entry.Run for ordinary tickets so a coordinator
can stop after a joined role call. The foundation/migration route refuses an
explicit limit before any role or directory reservation.

Add implementationModel and implementationModelEvidence to continue.md,
Entry.Continue and Ticket.Continue. Ticket.SelectModel admits the change only
at a confirmed paused implementation gate whose original Implementor has no
initialization, call, identity receipt or occupied reservation, retains the
authorization text as a document snapshot, and publishes a new continuation
with an implementationModelSelection receipt linking the one it replaces.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@taras
taras force-pushed the codex/sonnet-selection-1396 branch from 6c6853b to 52711fa Compare November 18, 2026 09:22

taras commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Verified final-head reviews for fa09a712c6fc03268a70e3ffb0882cd709fbe8cb:

  • Planner feedback: PASS, from the same explicitly identified bounded Codex substitute. It checked the final operator rebase and original criteria; the failed original Planner remains recorded separately.
  • Independent review: PASS, Codex Astra (gpt-6-astra), after the original Fable conversation could not resume before productive review output. The required fallback preserves both attempts and adds no review stage or correction allowance.
  • All three recorded acceptance clauses were examined; no blocking findings.

Independent review summary:

Reviewed the exact assigned revision against all three original acceptance clauses. No blocking correctness findings. The Sonnet test bodies and remaining original suite are preserved byte-for-byte. Discovery includes the new suite, production component routing is retained, and both entries have independent 120-second deadlines. Model selection, Session confirmation, joined continuation and caller invocation contracts are unchanged from the previously reviewed implementation. Reused passing final-head Node suite/typecheck evidence and applicable Deno runner/discovery evidence. No additional test execution was needed. The checkout remains unchanged and clean; every process started during this review completed. CI was not inspected.

The original Sonnet and Planner failures, all six historical calls, captured-input accounting and consumed first source-correction round remain preserved. Final-source Node production suites and typing pass; the Sonnet cases and their assertions are unchanged and each test entry retains its 120-second admission deadline.

Required CI and current-main health remain pending at publication of this note. The externally selected ready state is preserved; this report waives no gate and authorizes no merge.

taras commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Delivery completed for fa09a712c6fc03268a70e3ffb0882cd709fbe8cb.

Planner feedback and independent Codex Astra review are PASS; the independent findings and preserved role provenance are in the review record. Exact-head CI and main CI at 76535a3 passed. Native Delivery.Closeout confirmed the unchanged head, open/unmerged PR and all three gates passed, returning ready_for_merge with no remaining action except maintainer merge.

Taras’s ready state and rebased history are preserved. No merge was performed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant