Repository navigation
Keep journals and child output from failed test measurements - #1414
Conversation
|
Independent Codex Astra ( The reviewer confirmed that mismatch diagnostics run after child join, retain stdout/stderr and the complete parsed-record array, and preserve the original exact-130, cleanup, receipt-identity and successor assertions. It also confirmed that the separate failure-journal artifact cannot enter weights assembly, and that the workflow regression and owning specification agree. The reviewer inspected the retained controls and Deno/Node/typecheck evidence. The single Linux x64 Bun 1.4.0 probe passed both cases with 15 assertions, under emulation at a different workspace path; no hosted timing equivalence or exit-1 diagnosis is claimed. No additional runtime probe was needed for review. The original Planner separately PASSed this exact commit. These verdicts cover the diagnostic amendment only. #1331 remains open until a failing trace or deterministic witness identifies the production cause; required CI and maintainer merge remain delivery gates. |
|
Ready for maintainer merge. Required CI 44278975274, attempt 1 is successful on the exact reviewed The PR is already non-draft and mergeable; no merge was performed here. This remains a diagnostic amendment. #1331 stays open, and the separate fresh #1408 measurement 44279296345 is still running. |
Why
The weights measurement hit #1331's intermittent Bun failure: the headless Stop case exited with status 1 instead of 130. Its assertion omitted the child output and final receipt. The test saved its journals, but the measurement job uploaded only the weights record.
What changes
Before: an unexpected child exit showed a status mismatch, and the measurement runner discarded locally saved failure journals when it was removed.
After: the test reports the joined exit status, signal, captured stdout/stderr and parsed receipts on a mismatch. Failed or cancelled measurement jobs upload saved journals as a separate artifact, including hidden files.
Weights records keep their existing names, paths and complete-only assembly rules. The workflow regression checks the separate journal upload and excludes it from weights assembly.
How to verify it
Risks and limitations
This is a diagnostic change. It does not identify or repair the intermittent exit-1 cause. #1331 stays open until a failing trace or deterministic witness supports a production correction. The failed measurement attempt cannot supply final weights; #1408 still needs a complete new measurement and reviewed weights follow-up.
Scope confirmation
Original Planner and independent Codex Astra both PASS on signed
abc64a127b51bbd286698a550fa2723c8b836f2b, based on green main76535a3a. Required CI 44278975274 passes on that exact head: 62 successful jobs and one expected skip. Ready for maintainer merge.