Skip to content

Keep journals and child output from failed test measurements - #1414

Merged
taras merged 1 commit into
mainfrom
codex/headless-submit-exit-1331
Nov 18, 2026
Merged

taras merged 1 commit into
mainfrom
codex/headless-submit-exit-1331

Conversation

@taras

@taras taras commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Why

The weights measurement hit #1331's intermittent Bun failure: the headless Stop case exited with status 1 instead of 130. Its assertion omitted the child output and final receipt. The test saved its journals, but the measurement job uploaded only the weights record.

What changes

Before: an unexpected child exit showed a status mismatch, and the measurement runner discarded locally saved failure journals when it was removed.

After: the test reports the joined exit status, signal, captured stdout/stderr and parsed receipts on a mismatch. Failed or cancelled measurement jobs upload saved journals as a separate artifact, including hidden files.

Weights records keep their existing names, paths and complete-only assembly rules. The workflow regression checks the separate journal upload and excludes it from weights assembly.

How to verify it

  • The measurement workflow regression passes all 12 steps. Using the original workflow fails the new journal-retention check.
  • A deliberate expected-status mismatch fails and prints the actual status, child output and matching admitted/finished receipts.
  • Both process cases pass under Deno and Node; focused frozen typechecking and formatting pass.
  • One Linux x64 Bun 1.4.0 probe passes both cases with 15 assertions after setup with the CI toolchain. This used amd64 emulation and a different workspace path, so it does not establish hosted timing equivalence.

Risks and limitations

This is a diagnostic change. It does not identify or repair the intermittent exit-1 cause. #1331 stays open until a failing trace or deterministic witness supports a production correction. The failed measurement attempt cannot supply final weights; #1408 still needs a complete new measurement and reviewed weights follow-up.

Scope confirmation

  • Every changed file supports the purpose described above.
  • Unrelated cleanup and formatting changes are excluded.
  • Generated or mechanical changes are clearly identified: none.
  • The description matches the final diff and test results.

Original Planner and independent Codex Astra both PASS on signed abc64a127b51bbd286698a550fa2723c8b836f2b, based on green main 76535a3a. Required CI 44278975274 passes on that exact head: 62 successful jobs and one expected skip. Ready for maintainer merge.

taras commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Independent Codex Astra (gpt-6-astra) review: PASS on exact signed abc64a127b51bbd286698a550fa2723c8b836f2b. Native reviewer 01a1ee0a-0868-7800-9050-8e5433eb0c51 is independent of the Codex Implementor and original Planner. The review completed successfully, with no blocking findings and all six diagnostic acceptance clauses passing. Receipt SHA-256: ce37586bba03addc909db6e597e96981030bbab86775f3a620f11f9d7efdbe27.

The reviewer confirmed that mismatch diagnostics run after child join, retain stdout/stderr and the complete parsed-record array, and preserve the original exact-130, cleanup, receipt-identity and successor assertions. It also confirmed that the separate failure-journal artifact cannot enter weights assembly, and that the workflow regression and owning specification agree.

The reviewer inspected the retained controls and Deno/Node/typecheck evidence. The single Linux x64 Bun 1.4.0 probe passed both cases with 15 assertions, under emulation at a different workspace path; no hosted timing equivalence or exit-1 diagnosis is claimed. No additional runtime probe was needed for review.

The original Planner separately PASSed this exact commit. These verdicts cover the diagnostic amendment only. #1331 remains open until a failing trace or deterministic witness identifies the production cause; required CI and maintainer merge remain delivery gates.

taras commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Ready for maintainer merge. Required CI 44278975274, attempt 1 is successful on the exact reviewed abc64a127b51bbd286698a550fa2723c8b836f2b: all 63 jobs accounted for, 62 successful and one expected skip. Current base main 76535a3a is also green. Original Planner and independent Astra PASS are recorded above.

The PR is already non-draft and mergeable; no merge was performed here. This remains a diagnostic amendment. #1331 stays open, and the separate fresh #1408 measurement 44279296345 is still running.

@taras
taras merged commit b31a5cb into main Nov 18, 2026
67 checks passed
@taras
taras deleted the codex/headless-submit-exit-1331 branch November 18, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant