Taylor sills#1
Open
tdsills wants to merge 12 commits into
Open
Conversation
ghost
reviewed
Feb 20, 2021
| console.log("TEK"); | ||
| } if (i % 5 === 0) { | ||
| console.log("camp"); | ||
| } if (i % 3 === 0 && i % 5 === 0) { |
There was a problem hiding this comment.
We really don't want to have more than one "if" statement at a time. Generally, we would want to use "if else" and "else" after the first if. Multiple "if" statements can cause bugs.
ghost
reviewed
Feb 20, 2021
| // Write a function that returns a car object using some given info about your car. Required inputs are the make, model, year, and color. | ||
|
|
||
| //your code... | ||
| let myCar = { |
There was a problem hiding this comment.
We need to create a "parent" car object here that we use as a template for your "myCar" object. I'm also confused why you are only printing the "make" property instead of the entire car.
ghost
approved these changes
Feb 20, 2021
ghost
left a comment
There was a problem hiding this comment.
Good work, Taylor. I can tell you really gave MAXIMUM EFFORT on these exercises. Keep up the hard work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Matt,
Here are my exercises. I had issues with some, but I tried to get something for everything.
Thanks,
Taylor