Skip to content

refactor: improve pod log reading and status tracking#2787

Draft
chmouel wants to merge 1 commit intotektoncd:mainfrom
chmouel:refactor-pod-log-logic
Draft

refactor: improve pod log reading and status tracking#2787
chmouel wants to merge 1 commit intotektoncd:mainfrom
chmouel:refactor-pod-log-logic

Conversation

@chmouel
Copy link
Copy Markdown
Member

@chmouel chmouel commented Mar 31, 2026

  • Simplified pod status watching by replacing shared informers with a direct watch loop.
  • Added a fallback mechanism for retrieving TaskRun statuses when permissions to list resources are restricted.
  • Updated log reading logic to stop immediately when a container failure is detected.
  • Added comprehensive unit tests for container failure checks and retryable watch behavior.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 31, 2026
@tekton-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from chmouel after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 31, 2026
- Simplified pod status watching by replacing shared informers with a
  direct watch loop.
- Added a fallback mechanism for retrieving TaskRun statuses when
  permissions to list resources are restricted.
- Updated log reading logic to stop immediately when a container failure
  is detected.
- Added comprehensive unit tests for container failure checks and
  retryable watch behavior.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel chmouel force-pushed the refactor-pod-log-logic branch from 7f732c9 to 61ef738 Compare March 31, 2026 20:01
@chmouel chmouel marked this pull request as draft March 31, 2026 20:26
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants