Add group id for respond*task* operation and poll task response#735
Add group id for respond*task* operation and poll task response#735yux0 wants to merge 7 commits intotemporalio:masterfrom
Conversation
|
I don't see those APIs are in open api files. I am not sure if I missed them. I can borrow a second pair of eyes on this. |
yux0
changed the title
yux0
changed the title
| // aip.dev/not-precedent: We do not expose worker API to HTTP. --) | ||
| rpc RespondNexusTaskCompleted(RespondNexusTaskCompletedRequest) returns (RespondNexusTaskCompletedResponse) { | ||
| option (temporal.api.protometa.v1.request_header) = { | ||
| header: "temporal-poller-group-id" |
There was a problem hiding this comment.
I think we still want it to propagate to the temporal-resource-id header, right @ShahabT ?
There was a problem hiding this comment.
No, I don't think we need resource id anymore.
| // The run ID of the activity execution, only set for standalone activities. | ||
| string activity_run_id = 20; | ||
| // The identity of the poller group. | ||
| string poller_group_id = 21; |
There was a problem hiding this comment.
I don't think PollActivityTaskQueueResponse needs this
There was a problem hiding this comment.
Removed from Poll*TaskQueueResponse.
| // Why did the task fail? It's important to note that many of the variants in this enum cannot | ||
| // apply to worker responses. See the type's doc for more. | ||
| temporal.api.enums.v1.WorkflowTaskFailedCause cause = 8; | ||
| string poller_group_id = 9; |
There was a problem hiding this comment.
Everything should get a comment. Applies to other spot too.
In addition, the comments aren't particularly helpful. They should explain the semantics the SDK is expected to adhere to when setting/reading these fields.
5 participants
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
What changed?
Add group id for respondtask operation and poll task response
Why?
We need a way to route request to the correct owner of the nexus task.